Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[.NET 6] Backport WinForms & WPF CSS Hot Reload Fixes #9787

Merged
merged 3 commits into from
Aug 31, 2022
Merged

[.NET 6] Backport WinForms & WPF CSS Hot Reload Fixes #9787

merged 3 commits into from
Aug 31, 2022

Conversation

TanayParikh
Copy link
Contributor

@TanayParikh TanayParikh commented Aug 30, 2022 •
edited by samhouts
Loading

Backport of #9645

Fixes #7479

@TanayParikh
AutoCloseOnReadCompleteStream
ac84eb6 
(cherry picked from commit 8dd1316)
@TanayParikh
Ensure old response content is closed out for hot reload
81e6f86 
(cherry picked from commit ebdfdf4)
@TanayParikh
PR Feedback
0b54ff9 
(cherry picked from commit 122426c)
@TanayParikh TanayParikh requested a review from a team as a code owner August 30, 2022 18:33
@TanayParikh TanayParikh self-assigned this Aug 30, 2022
@TanayParikh TanayParikh added the 7.0-rc2 Created by mkArtakMSFT label Aug 30, 2022
@TanayParikh TanayParikh added this to the 7.0-rc2 milestone Aug 30, 2022
@TanayParikh TanayParikh added area-blazor Blazor Hybrid / Desktop, BlazorWebView feature-blazor-windesktop Issues in Blazor in WPF or WinForms labels Aug 30, 2022
@TanayParikh TanayParikh mentioned this pull request Aug 30, 2022
Closed
@mattleibow
Copy link
Member

This says net6 in the title but is against main? Should this be against net6.0 branch?

@TanayParikh TanayParikh changed the base branch from main to net6.0 August 31, 2022 05:11
@TanayParikh TanayParikh removed the 7.0-rc2 Created by mkArtakMSFT label Aug 31, 2022
@TanayParikh TanayParikh modified the milestones: 7.0-rc2, 6.0-sr5 Aug 31, 2022
@TanayParikh
Copy link
Contributor Author

Should this be against net6.0 branch?

Yes. Yes it should 🤦 . Thanks for calling that out 😄

@rmarinho rmarinho requested a review from Eilon August 31, 2022 15:03
@rmarinho rmarinho merged commit a8e4d78 into net6.0 Aug 31, 2022
@rmarinho rmarinho deleted the taparik/backport_9645 branch August 31, 2022 15:55
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2023
@samhouts samhouts added fixed-in-6.0.540 Look for this fix in 6.0.540 SR5! fixed-in-7.0.0-rc.1.6683 labels Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Eilon Eilon Eilon approved these changes

Assignees

@TanayParikh TanayParikh

Labels
area-blazor Blazor Hybrid / Desktop, BlazorWebView feature-blazor-windesktop Issues in Blazor in WPF or WinForms fixed-in-6.0.540 Look for this fix in 6.0.540 SR5! fixed-in-7.0.0-rc.1.6683
Projects
None yet
Milestone
6.0-sr5
Development

Successfully merging this pull request may close these issues.

BlazorWebView on Windows Forms locks CSS files while the app is running
5 participants
@TanayParikh @mattleibow @Eilon @rmarinho @samhouts