Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly size the Android 12 splash screen #9797

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

mattleibow
Copy link
Member

Description of Change

This PR make sure the splash image on Android 12+ fits withing the visible area. The image is still currently stretched and this will have to be fixed in another PR as this involves changing the rendering code, but for now if the source image is a square, then all is well.

Issues Fixed

Fixes #9794

NOTE: the splash image is still stretched because Android does not support an "aspect fill/fit", so we will have to do that ourselves. And the image is clipped on the corners because our image goes right to the end of the image, and it is being rendered in a circle.
To get a good splash screen image, make sure the it is square and fits within a circle.

Before After
Screenshot_1661910728 Screenshot_1661910266

@mattleibow mattleibow changed the base branch from main to net6.0 August 31, 2022 01:55
@mattleibow mattleibow added this to the 6.0-sr5 milestone Aug 31, 2022
@mattleibow mattleibow added area-single-project Splash Screen, Multi-Targeting, MauiFont, MauiImage, MauiAsset, Resizetizer platform/android 🤖 labels Aug 31, 2022
@level2fast
Copy link

I'm seeing this issue as well.

@angelru
Copy link

angelru commented Dec 21, 2022

and me, is this solved?

@Mashedpoturtles
Copy link

is this fixed yet? having the same problem

@fgiacomelli
Copy link

Same problem for me, I tried the solution suggested in #9794 from @mattleibow but it lacks some informations:

  • where do we have to place the file used as main image (the one you write as "name_of_your_splash_image") and what are the build action that we have to set?
  • what is the build action that we have to use for the \maui_splash.xml file?

please if your workaround really works with Android 12 provide us a detailed and working sample because I tested with a lot of combinations and none works.

@mhrastegari
Copy link

Still seeing this using .NET 7.0.102 :(

@mattleibow
Copy link
Member Author

What are you seeing @mhrastegari? This PR is about the aspect ratio of the image. You may be seeing the new feature of Android to not support the full screen splash. They only support "icons" now. See also #7404

Please open a new issue with a screenshot if it is not the new, small circle splash format from Google. We can't really do anything. Probably in the next android they will change again, so best we can do is hope they un-decide to make this horrible decision.

@Mugiljs
Copy link

Mugiljs commented Nov 20, 2023

Hi, Where can i find the full repo?

@mosabbir786
Copy link

mosabbir786 commented Nov 29, 2023

Splash Image displayed in a circle and cut off , but i want to display in full screen

@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2023
@samhouts samhouts added fixed-in-6.0.540 Look for this fix in 6.0.540 SR5! fixed-in-7.0.0-rc.1.6683 labels Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-single-project Splash Screen, Multi-Targeting, MauiFont, MauiImage, MauiAsset, Resizetizer fixed-in-6.0.540 Look for this fix in 6.0.540 SR5! fixed-in-7.0.0-rc.1.6683 platform/android 🤖
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add better support for Android 12+ Splash Screen APIs
10 participants