Skip to content

Fix reading GUIDs from delta metadata #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025
Merged

Fix reading GUIDs from delta metadata #308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 32 additions & 3 deletions src/Microsoft.Metadata.Visualizer/MetadataVisualizer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -938,12 +938,41 @@ private string Literal(Handle handle, Func<MetadataReader, Handle, string> getVa

if (_aggregator != null)
{
Handle generationHandle = _aggregator.GetGenerationHandle(handle, out int generation);
Handle generationHandle;
int generation;

// workaround for https://github.com/dotnet/runtime/issues/113910
if (handle.Kind == HandleKind.Guid)
{
generationHandle = handle;
generation = -1;

var guidOffset = MetadataTokens.GetHeapOffset(handle);

for (int i = 0; i < _readers.Count; i++)
{
if (guidOffset <= _readers[i].GetHeapSize(HeapIndex.Guid) / 16)
{
generation = i;
break;
}
}

if (generation < 0)
{
return BadMetadataStr;
}
}
else
{
generationHandle = _aggregator.GetGenerationHandle(handle, out generation);
}

var generationReader = _readers[generation];
var offset = generationReader.GetHeapOffset(handle);
var generationOffset = generationReader.GetHeapOffset(generationHandle);

string value = GetValueChecked(getValue, generationReader, generationHandle);
int offset = generationReader.GetHeapOffset(handle);
int generationOffset = generationReader.GetHeapOffset(generationHandle);

if (noHeapReferences)
{
Expand Down