Support WarningsAsErrors as MSBuildWarningsAsErrors (#5774)

In same feature flag as NoWarn (can change to a separate feature flag if desired.) Addition to #4421.
dotnet · Oct 30, 2020 · 47e6ac1 · 47e6ac1
1 parent b41ff04
commit 47e6ac1
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/Tasks/Microsoft.Common.CurrentVersion.targets b/src/Tasks/Microsoft.Common.CurrentVersion.targets
@@ -614,8 +614,9 @@ Copyright (C) Microsoft Corporation. All rights reserved.
   </PropertyGroup>
 
   <!-- Users familiar with how some other repos work try to use NoWarn with MSBuild in place of MSBuildWarningsAsMessages. -->
-  <PropertyGroup Condition="'$(MSBuildWarningsAsMessages)'=='' And $([MSBuild]::AreFeaturesEnabled('16.8'))">
-    <MSBuildWarningsAsMessages>$(NoWarn)</MSBuildWarningsAsMessages>
+  <PropertyGroup Condition="$([MSBuild]::AreFeaturesEnabled('16.8'))">
+    <MSBuildWarningsAsMessages Condition="'$(MSBuildWarningsAsMessages)'==''">$(NoWarn)</MSBuildWarningsAsMessages>
+    <MSBuildWarningsAsErrors Condition="'$(MSBuildWarningsAsErrors)'==''">$(WarningsAsErrors)</MSBuildWarningsAsErrors>
   </PropertyGroup>
 
   <!-- Common Project System support -->