Skip to content

Commit

Permalink
Add suppressions for api differences between main and vs17.8
Browse files Browse the repository at this point in the history
  • Loading branch information
GangWang01 committed Oct 25, 2023
1 parent 8f68a8c commit 676d908
Show file tree
Hide file tree
Showing 2 changed files with 338 additions and 0 deletions.
57 changes: 57 additions & 0 deletions src/Build/CompatibilitySuppressions.xml
Original file line number Diff line number Diff line change
@@ -1,4 +1,61 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- https://learn.microsoft.com/en-us/dotnet/fundamentals/package-validation/diagnostic-ids -->
<Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
<!-- Suppressions for api differences between main and vs17.8 when merging vs17.8 into main -->
<Suppression>
<DiagnosticId>CP0002</DiagnosticId>
<Target>M:Microsoft.Build.Experimental.ProjectCache.ProjectCachePluginBase.HandleFileAccess(Microsoft.Build.Experimental.ProjectCache.FileAccessContext,Microsoft.Build.Framework.FileAccess.FileAccessData)</Target>
<Left>lib/net472/Microsoft.Build.dll</Left>
<Right>lib/net472/Microsoft.Build.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0002</DiagnosticId>
<Target>M:Microsoft.Build.Experimental.ProjectCache.ProjectCachePluginBase.HandleProcess(Microsoft.Build.Experimental.ProjectCache.FileAccessContext,Microsoft.Build.Framework.FileAccess.ProcessData)</Target>
<Left>lib/net472/Microsoft.Build.dll</Left>
<Right>lib/net472/Microsoft.Build.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0002</DiagnosticId>
<Target>M:Microsoft.Build.Experimental.ProjectCache.ProjectCachePluginBase.HandleFileAccess(Microsoft.Build.Experimental.ProjectCache.FileAccessContext,Microsoft.Build.Framework.FileAccess.FileAccessData)</Target>
<Left>lib/net8.0/Microsoft.Build.dll</Left>
<Right>lib/net8.0/Microsoft.Build.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0002</DiagnosticId>
<Target>M:Microsoft.Build.Experimental.ProjectCache.ProjectCachePluginBase.HandleProcess(Microsoft.Build.Experimental.ProjectCache.FileAccessContext,Microsoft.Build.Framework.FileAccess.ProcessData)</Target>
<Left>lib/net8.0/Microsoft.Build.dll</Left>
<Right>lib/net8.0/Microsoft.Build.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0002</DiagnosticId>
<Target>M:Microsoft.Build.Experimental.ProjectCache.ProjectCachePluginBase.HandleFileAccess(Microsoft.Build.Experimental.ProjectCache.FileAccessContext,Microsoft.Build.Framework.FileAccess.FileAccessData)</Target>
<Left>ref/net472/Microsoft.Build.dll</Left>
<Right>ref/net472/Microsoft.Build.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0002</DiagnosticId>
<Target>M:Microsoft.Build.Experimental.ProjectCache.ProjectCachePluginBase.HandleProcess(Microsoft.Build.Experimental.ProjectCache.FileAccessContext,Microsoft.Build.Framework.FileAccess.ProcessData)</Target>
<Left>ref/net472/Microsoft.Build.dll</Left>
<Right>ref/net472/Microsoft.Build.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0002</DiagnosticId>
<Target>M:Microsoft.Build.Experimental.ProjectCache.ProjectCachePluginBase.HandleFileAccess(Microsoft.Build.Experimental.ProjectCache.FileAccessContext,Microsoft.Build.Framework.FileAccess.FileAccessData)</Target>
<Left>ref/net8.0/Microsoft.Build.dll</Left>
<Right>ref/net8.0/Microsoft.Build.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0002</DiagnosticId>
<Target>M:Microsoft.Build.Experimental.ProjectCache.ProjectCachePluginBase.HandleProcess(Microsoft.Build.Experimental.ProjectCache.FileAccessContext,Microsoft.Build.Framework.FileAccess.ProcessData)</Target>
<Left>ref/net8.0/Microsoft.Build.dll</Left>
<Right>ref/net8.0/Microsoft.Build.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
</Suppressions>
281 changes: 281 additions & 0 deletions src/Framework/CompatibilitySuppressions.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,287 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- https://learn.microsoft.com/en-us/dotnet/fundamentals/package-validation/diagnostic-ids -->
<Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
<!-- Suppressions for api differences between main and vs17.8 when merging vs17.8 into main -->
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Microsoft.Build.Framework.FileAccess.DesiredAccess</Target>
<Left>lib/net472/Microsoft.Build.Framework.dll</Left>
<Right>lib/net472/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Microsoft.Build.Framework.FileAccess.FileAccessData</Target>
<Left>lib/net472/Microsoft.Build.Framework.dll</Left>
<Right>lib/net472/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Microsoft.Build.Framework.FileAccess.FlagsAndAttributes</Target>
<Left>lib/net472/Microsoft.Build.Framework.dll</Left>
<Right>lib/net472/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Microsoft.Build.Framework.FileAccess.ProcessData</Target>
<Left>lib/net472/Microsoft.Build.Framework.dll</Left>
<Right>lib/net472/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Microsoft.Build.Framework.FileAccess.ReportedFileOperation</Target>
<Left>lib/net472/Microsoft.Build.Framework.dll</Left>
<Right>lib/net472/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Microsoft.Build.Framework.FileAccess.RequestedAccess</Target>
<Left>lib/net472/Microsoft.Build.Framework.dll</Left>
<Right>lib/net472/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Microsoft.Build.Framework.FileAccess.DesiredAccess</Target>
<Left>lib/net8.0/Microsoft.Build.Framework.dll</Left>
<Right>lib/net8.0/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Microsoft.Build.Framework.FileAccess.FileAccessData</Target>
<Left>lib/net8.0/Microsoft.Build.Framework.dll</Left>
<Right>lib/net8.0/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Microsoft.Build.Framework.FileAccess.FlagsAndAttributes</Target>
<Left>lib/net8.0/Microsoft.Build.Framework.dll</Left>
<Right>lib/net8.0/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Microsoft.Build.Framework.FileAccess.ProcessData</Target>
<Left>lib/net8.0/Microsoft.Build.Framework.dll</Left>
<Right>lib/net8.0/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Microsoft.Build.Framework.FileAccess.ReportedFileOperation</Target>
<Left>lib/net8.0/Microsoft.Build.Framework.dll</Left>
<Right>lib/net8.0/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Microsoft.Build.Framework.FileAccess.RequestedAccess</Target>
<Left>lib/net8.0/Microsoft.Build.Framework.dll</Left>
<Right>lib/net8.0/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Microsoft.Build.Framework.FileAccess.DesiredAccess</Target>
<Left>ref/net472/Microsoft.Build.Framework.dll</Left>
<Right>ref/net472/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Microsoft.Build.Framework.FileAccess.FileAccessData</Target>
<Left>ref/net472/Microsoft.Build.Framework.dll</Left>
<Right>ref/net472/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Microsoft.Build.Framework.FileAccess.FlagsAndAttributes</Target>
<Left>ref/net472/Microsoft.Build.Framework.dll</Left>
<Right>ref/net472/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Microsoft.Build.Framework.FileAccess.ProcessData</Target>
<Left>ref/net472/Microsoft.Build.Framework.dll</Left>
<Right>ref/net472/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Microsoft.Build.Framework.FileAccess.ReportedFileOperation</Target>
<Left>ref/net472/Microsoft.Build.Framework.dll</Left>
<Right>ref/net472/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Microsoft.Build.Framework.FileAccess.RequestedAccess</Target>
<Left>ref/net472/Microsoft.Build.Framework.dll</Left>
<Right>ref/net472/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Microsoft.Build.Framework.FileAccess.DesiredAccess</Target>
<Left>ref/net8.0/Microsoft.Build.Framework.dll</Left>
<Right>ref/net8.0/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Microsoft.Build.Framework.FileAccess.FileAccessData</Target>
<Left>ref/net8.0/Microsoft.Build.Framework.dll</Left>
<Right>ref/net8.0/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Microsoft.Build.Framework.FileAccess.FlagsAndAttributes</Target>
<Left>ref/net8.0/Microsoft.Build.Framework.dll</Left>
<Right>ref/net8.0/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Microsoft.Build.Framework.FileAccess.ProcessData</Target>
<Left>ref/net8.0/Microsoft.Build.Framework.dll</Left>
<Right>ref/net8.0/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Microsoft.Build.Framework.FileAccess.ReportedFileOperation</Target>
<Left>ref/net8.0/Microsoft.Build.Framework.dll</Left>
<Right>ref/net8.0/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Microsoft.Build.Framework.FileAccess.RequestedAccess</Target>
<Left>ref/net8.0/Microsoft.Build.Framework.dll</Left>
<Right>ref/net8.0/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Microsoft.Build.Framework.FileAccess.DesiredAccess</Target>
<Left>ref/netstandard2.0/Microsoft.Build.Framework.dll</Left>
<Right>ref/netstandard2.0/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Microsoft.Build.Framework.FileAccess.FileAccessData</Target>
<Left>ref/netstandard2.0/Microsoft.Build.Framework.dll</Left>
<Right>ref/netstandard2.0/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Microsoft.Build.Framework.FileAccess.FlagsAndAttributes</Target>
<Left>ref/netstandard2.0/Microsoft.Build.Framework.dll</Left>
<Right>ref/netstandard2.0/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Microsoft.Build.Framework.FileAccess.ProcessData</Target>
<Left>ref/netstandard2.0/Microsoft.Build.Framework.dll</Left>
<Right>ref/netstandard2.0/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Microsoft.Build.Framework.FileAccess.ReportedFileOperation</Target>
<Left>ref/netstandard2.0/Microsoft.Build.Framework.dll</Left>
<Right>ref/netstandard2.0/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Microsoft.Build.Framework.FileAccess.RequestedAccess</Target>
<Left>ref/netstandard2.0/Microsoft.Build.Framework.dll</Left>
<Right>ref/netstandard2.0/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0002</DiagnosticId>
<Target>F:Microsoft.Build.Framework.EngineServices.Version2</Target>
<Left>lib/net472/Microsoft.Build.Framework.dll</Left>
<Right>lib/net472/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0002</DiagnosticId>
<Target>M:Microsoft.Build.Framework.EngineServices.ReportFileAccess(Microsoft.Build.Framework.FileAccess.FileAccessData)</Target>
<Left>lib/net472/Microsoft.Build.Framework.dll</Left>
<Right>lib/net472/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0002</DiagnosticId>
<Target>F:Microsoft.Build.Framework.EngineServices.Version2</Target>
<Left>lib/net8.0/Microsoft.Build.Framework.dll</Left>
<Right>lib/net8.0/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0002</DiagnosticId>
<Target>M:Microsoft.Build.Framework.EngineServices.ReportFileAccess(Microsoft.Build.Framework.FileAccess.FileAccessData)</Target>
<Left>lib/net8.0/Microsoft.Build.Framework.dll</Left>
<Right>lib/net8.0/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0002</DiagnosticId>
<Target>F:Microsoft.Build.Framework.EngineServices.Version2</Target>
<Left>ref/net472/Microsoft.Build.Framework.dll</Left>
<Right>ref/net472/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0002</DiagnosticId>
<Target>M:Microsoft.Build.Framework.EngineServices.ReportFileAccess(Microsoft.Build.Framework.FileAccess.FileAccessData)</Target>
<Left>ref/net472/Microsoft.Build.Framework.dll</Left>
<Right>ref/net472/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0002</DiagnosticId>
<Target>F:Microsoft.Build.Framework.EngineServices.Version2</Target>
<Left>ref/net8.0/Microsoft.Build.Framework.dll</Left>
<Right>ref/net8.0/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0002</DiagnosticId>
<Target>M:Microsoft.Build.Framework.EngineServices.ReportFileAccess(Microsoft.Build.Framework.FileAccess.FileAccessData)</Target>
<Left>ref/net8.0/Microsoft.Build.Framework.dll</Left>
<Right>ref/net8.0/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0002</DiagnosticId>
<Target>F:Microsoft.Build.Framework.EngineServices.Version2</Target>
<Left>ref/netstandard2.0/Microsoft.Build.Framework.dll</Left>
<Right>ref/netstandard2.0/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0002</DiagnosticId>
<Target>M:Microsoft.Build.Framework.EngineServices.ReportFileAccess(Microsoft.Build.Framework.FileAccess.FileAccessData)</Target>
<Left>ref/netstandard2.0/Microsoft.Build.Framework.dll</Left>
<Right>ref/netstandard2.0/Microsoft.Build.Framework.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<!-- PKV004 for netstandard2.0-supporting TFs that we do not have runtime assemblies for.
This is intentional, because you can only use MSBuild in the context of a .NET SDK
(on net7.0, as of MSBuild 17.4) or in the context of Visual Studio (net472), but we
Expand Down

0 comments on commit 676d908

Please sign in to comment.