Skip to content

Commit

Permalink
jnm2.ReferenceAssemblies.net35 should be a private dependency (#6214)
Browse files Browse the repository at this point in the history
  • Loading branch information
dfederm authored Mar 3, 2021
1 parent a71a130 commit 95415a2
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions src/MSBuildTaskHost/MSBuildTaskHost.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<Import Project="$(RepoRoot)eng\ProducesNoOutput.Settings.props" Condition="'$(MSBuildRuntimeType)' == 'Core' or '$(MonoBuild)' == 'true'" />

<PropertyGroup>
<TargetFramework>net35</TargetFramework>
<TargetFramework>net35</TargetFramework>
<OutputType>Exe</OutputType>
<PlatformTarget Condition="'$(Platform)' == 'x64'">x64</PlatformTarget>
<PlatformTarget Condition="'$(Platform)' == 'AnyCPU'">x86</PlatformTarget>
Expand All @@ -14,12 +14,12 @@
This is important for the MSBuild.VSSetup project, which "references" both the x86 and x64
versions of this project -->
<RuntimeIdentifiers>win7-x86;win7-x64</RuntimeIdentifiers>

<EnableDefaultItems>false</EnableDefaultItems>
<DefineConstants>$(DefineConstants);CLR2COMPATIBILITY</DefineConstants>
<!-- Need pointers for getting environment block -->
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<!-- It is vital that msbuildtaskhost.exe is allowed to use the full 4GB on 64 bit machines in order to help avoid
<!-- It is vital that msbuildtaskhost.exe is allowed to use the full 4GB on 64 bit machines in order to help avoid
out of memory problems on large trees -->
<LargeAddressAware>true</LargeAddressAware>
<ApplicationIcon>..\MSBuild\MSBuild.ico</ApplicationIcon>
Expand Down Expand Up @@ -209,7 +209,7 @@
<PackageReference Include="PdbGit" /> -->
<PackageReference Include="SourceLink.Create.CommandLine" />
<PackageReference Include="LargeAddressAware" PrivateAssets="All" />
<PackageReference Include="jnm2.ReferenceAssemblies.net35" />
<PackageReference Include="jnm2.ReferenceAssemblies.net35" PrivateAssets="All" />
</ItemGroup>
<ItemGroup Condition="'$(TargetFrameworkIdentifier)' != '.NETFramework'">
<!-- Need Win32 API on .NET Core to ping registry to determine long path support -->
Expand Down
2 changes: 1 addition & 1 deletion src/StringTools/StringTools.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
<PackageReference Include="System.Runtime.CompilerServices.Unsafe" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="jnm2.ReferenceAssemblies.net35" />
<PackageReference Include="jnm2.ReferenceAssemblies.net35" PrivateAssets="All" />
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' == 'net35'">
Expand Down

0 comments on commit 95415a2

Please sign in to comment.