Clarify comment about MSBuildLoadContext test

The confusing situation can be resolved by an IVT change, filed as #5041.
dotnet · Jan 9, 2020 · f561312 · f561312
1 parent 6d4c3b1
commit f561312
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/MSBuild.UnitTests/ValidateAssemblyLoadContext.cs b/src/MSBuild.UnitTests/ValidateAssemblyLoadContext.cs
@@ -16,8 +16,11 @@ public override bool Execute()
         {
             var thisLoadContext = AssemblyLoadContext.GetLoadContext(typeof(ValidateAssemblyLoadContext).Assembly);
 
-            // Check by name because this always reports false, presumably due to ALC shenanigans:
-            // if (thisLoadContext is MSBuildLoadContext context)
+            // The straightforward implementation of this check:
+            //   if (thisLoadContext is MSBuildLoadContext context)
+            // fails here because MSBuildLoadContext (in this test assembly) is from MSBuild.exe via
+            // IVT, but the one that actually gets used for task isolation is in Microsoft.Build.dll.
+            // This probably doesn't need to be how it is forever: https://github.com/microsoft/msbuild/issues/5041
             if (thisLoadContext.GetType().FullName == typeof(MSBuildLoadContext).FullName)
             {
 #if NETCOREAPP && !NETCOREAPP2_1 // TODO: enable this functionality when targeting .NET Core 3.0+