Skip to content

Remove shared source files #11494

@MichalPavlik

Description

@MichalPavlik

MSBuild repo historically uses source files shared across several projects. This is causing increased NGEN/JIT time, increased assembly size and mainly we are not able to factor our code in the right way due to type full name conflicts.

This problem could be resolved by several sequential steps/PRs:

  • Identify and resolve all resource duplicates in our projects
  • Merge all resources to a single resource file inside Microsoft.Build.Framework project. Move ResourceUtilities and ErrorUtilities to the Microsoft.Build.Framework and add AssemblyResources to make ResourceUtilities work as intended. Remove AssemblyResources files from projects with removed resources. Share the new resource file with MSBuildTaskHost and fix links to ResourceUtilities and ErrorUtilities.'
  • Remove shared files in the MSBuild project. This will unlock enablement of Microsoft.Build internal types visibility and allow us to move some logic from ``MSBuildassembly toMicrosoft.Build`.
  • Incrementally remove rest of the shared sources (move them to the Framework project)

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions