Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSBuild VSIX should depend on NuGet VSIX that delivers core logic #3852

Closed
rainersigwald opened this issue Oct 11, 2018 · 1 comment
Closed

MSBuild VSIX should depend on NuGet VSIX that delivers core logic #3852

rainersigwald opened this issue Oct 11, 2018 · 1 comment
Assignees
@rainersigwald
Labels
triaged
Milestone
MSBuild 16.0

Comments

@rainersigwald
Copy link
Member

See details in NuGet/Home#7390. Moving the manifest would need a coordinated change here and in NuGet.Client.
@rainersigwald rainersigwald mentioned this issue Oct 11, 2018
Closed
@rchande rchande mentioned this issue Nov 20, 2018
Closed
@rainersigwald
Copy link
Member Author

IIRC offline we decided that this was sufficiently core functionality that instead of moving the manifest we should make the MSBuild vsix depend on the NuGet VSIX that delivers the resolver.

@rainersigwald rainersigwald changed the title NuGet VSIX should ship Microsoft.Build.NuGetSdkResolver manifest MSBuild VSIX should depend on NuGet VSIX that delivers core logic Dec 13, 2018
@rainersigwald rainersigwald added this to the MSBuild 16.0 milestone Dec 13, 2018
rainersigwald added a commit to rainersigwald/msbuild that referenced this issue Jan 31, 2019
@rainersigwald
VSIX dependency on NuGet.BuildTools
34b20fa 
Fixes dotnet#3852 by ensuring that NuGet's tasks and targets are present
wherever MSBuild itself is, since common.targets now depends on NuGet.

Closes NuGet/Home#7390.
@rainersigwald rainersigwald mentioned this issue Feb 6, 2019
Merged
@rainersigwald rainersigwald self-assigned this Feb 6, 2019
rainersigwald added a commit that referenced this issue Feb 8, 2019
@rainersigwald
VSIX dependency on NuGet.BuildTools (#4146)
7146e58 
Fixes #3852 by ensuring that NuGet's tasks and targets are present
wherever MSBuild itself is, since common.targets now depends on NuGet.

Closes NuGet/Home#7390.
@rainersigwald rainersigwald mentioned this issue Feb 8, 2019
Merged
rainersigwald added a commit that referenced this issue Feb 8, 2019
@rainersigwald
VSIX dependency on NuGet.BuildTools (#4159)
ed51805 
Fixes #3852 by ensuring that NuGet's tasks and targets are present
wherever MSBuild itself is, since common.targets now depends on NuGet.

Closes NuGet/Home#7390.
@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rainersigwald rainersigwald

Labels
triaged
Projects
None yet
Milestone
MSBuild 16.0
Development

No branches or pull requests
2 participants
@rainersigwald @AR-May