Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove probing for .ni.dll when loading .NET Core assemblies #5042

Closed
rainersigwald opened this issue Jan 9, 2020 · 0 comments · Fixed by #6663
Closed

Remove probing for .ni.dll when loading .NET Core assemblies #5042

rainersigwald opened this issue Jan 9, 2020 · 0 comments · Fixed by #6663
Assignees
@rainersigwald
Labels
triaged
Milestone
VS 17.0

Comments

@rainersigwald
Copy link
Member

#4916 (comment)

if I'm not mistaken ni.dll and ni.exe are holdovers from early days of CoreCLR and not something we need to support. Potentially could speed things up to stop probing for them. Or at least move them to the end of the list?

https://github.com/microsoft/msbuild/blob/8d37fbb97003e96516a2054e51dd5fabfd720ed6/src/Shared/CoreCLRAssemblyLoader.cs#L25
@rainersigwald rainersigwald mentioned this issue Jan 9, 2020
Merged
@rainersigwald rainersigwald added this to the .NET 5 milestone Jan 13, 2020
@rainersigwald rainersigwald modified the milestones: .NET 5, 17.0 Jun 15, 2021
@marcpopMSFT marcpopMSFT modified the milestones: 17.0, MSBuild 17.1 Jul 9, 2021
@rainersigwald rainersigwald self-assigned this Jul 12, 2021
rainersigwald added a commit to rainersigwald/msbuild that referenced this issue Jul 12, 2021
@rainersigwald
Stop checking .ni.dll/exe on Core
d26cfbe 
We believe these were remnants of old pre-crossgen file naming patterns that haven't been used in a very long time.

Removing the checks to avoid filesystem activity on files that almost certainly will not exist.

Fixes dotnet#5042.
@rainersigwald rainersigwald mentioned this issue Jul 12, 2021
Merged
@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rainersigwald rainersigwald

Labels
triaged
Projects
None yet
Milestone
VS 17.0
Development

Successfully merging a pull request may close this issue.

Stop checking .ni.dll/exe on Core rainersigwald/msbuild
3 participants
@rainersigwald @marcpopMSFT @AR-May