Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSBuild Server v1 #6494

Closed
4 tasks
rokonec opened this issue May 27, 2021 · 3 comments
Closed
4 tasks

MSBuild Server v1 #6494

rokonec opened this issue May 27, 2021 · 3 comments
Labels
backlog For consideration Used for items on the backlog to raise them to the top of that list for discussion performance Performance-Scenario-Build This issue affects build performance. triaged
Milestone

Comments

@rokonec
Copy link
Member

rokonec commented May 27, 2021

To improve inner loop experience of building small project fast in scenarios:

  • dotnet new console
  • dotnet build/run

We force MSBuild to always use external reusable nodes/processes to build projects.

Measured improvement: #6467

Implementation:

  • Modify SDK to set MSBUILDNOINPROCNODE = 1
  • Implement escape hatches DOTNET_DO_NOT_USE_MSBUILDNOINPROCNODE = 1

--------------------------------------- PARKED ------------------------------------

TODO: bellov

During dogfooding we have identified few issues with current solution. All off below has to be somehow addressed for MSBuild V1 to be turned on by default:

@rokonec rokonec added performance Performance-Scenario-Build This issue affects build performance. labels May 27, 2021
@rokonec rokonec self-assigned this May 27, 2021
@rokonec rokonec mentioned this issue May 27, 2021
7 tasks
rokonec added a commit to rokonec/sdk that referenced this issue May 27, 2021
rokonec added a commit to dotnet/sdk that referenced this issue May 28, 2021
To improve inner loop experience of building small project fast in scenarios:

dotnet new console
dotnet build/run
We force MSBuild to always use external reusable nodes/processes to build projects.

Measured improvement: dotnet/msbuild#6467

Implementation:

Modify SDK to set MSBUILDNOINPROCNODE = 1
Implement escape hatches DOTNET_DO_NOT_USE_MSBUILDNOINPROCNODE = 1

Also see: dotnet/msbuild#6494
@rokonec
Copy link
Member Author

rokonec commented Jun 21, 2021

Changes had made it into Installer.

@rokonec rokonec closed this as completed Jun 21, 2021
@rokonec rokonec reopened this Jun 29, 2021
@rokonec
Copy link
Member Author

rokonec commented Jun 29, 2021

There are couple of known issues:

  • when building SLN by arcade in linux
  • when extension using Console.WriteLine as oppose to Logger.LogMessage.

@rokonec rokonec removed their assignment Jul 19, 2021
@rokonec rokonec added backlog For consideration Used for items on the backlog to raise them to the top of that list for discussion labels Jul 19, 2021
@ladipro
Copy link
Member

ladipro commented Aug 4, 2021

Closing for now as we don't have resources to work through the issues.

@ladipro ladipro closed this as completed Aug 4, 2021
@ladipro ladipro added this to the VS 17.0 milestone Dec 8, 2021
@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog For consideration Used for items on the backlog to raise them to the top of that list for discussion performance Performance-Scenario-Build This issue affects build performance. triaged
Projects
None yet
Development

No branches or pull requests

3 participants