You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The non-Framework / non-Windows implementation of RAR has a bug where it incorrectly assumes that the metadata version - referred to as "runtime version" in the code - has to start with 'v'. Metadata version of WinRT files looks like WindowsRuntime 1.4 or WindowsRuntime 1.4;CLR v4.0.30319.
Steps to Reproduce
Create a WinRT component using the Windows Runtime Component template in VS and add it as a reference to a .NET project. Build the project.
It's not clear what the downstream effect is. Since .winmd's cannot be referenced by modern .NET projects anyway - the build errors out in the CheckForUnsupportedWinMDReferences task - it is possible that this part of Core RAR may be deleted.
Versions & Configurations
MSBuild version 17.6.0-preview-23174-01+e7de13307 for .NET
The text was updated successfully, but these errors were encountered:
Fixes#8731
Context
The .NET Core version of MSBuild has its own metadata reader implementation and GetRuntimeVersion contains checks that are stricter than what the full Framework implementation does. Specifically, it allows only "version-like" runtime versions, which makes it fail to read the version of WinRT assemblies.
Changes Made
Removed the incorrect checks.
Testing
New unit test.
Verified that referencing a WinRT assembly now makes RAR produce the right output.
Issue Description
The non-Framework / non-Windows implementation of RAR has a bug where it incorrectly assumes that the metadata version - referred to as "runtime version" in the code - has to start with 'v'. Metadata version of WinRT files looks like
WindowsRuntime 1.4
orWindowsRuntime 1.4;CLR v4.0.30319
.Steps to Reproduce
Create a WinRT component using the Windows Runtime Component template in VS and add it as a reference to a .NET project. Build the project.
Expected Behavior
Actual Behavior
Analysis
Here's the bug:
msbuild/src/Tasks/AssemblyDependency/AssemblyInformation.cs
Lines 1051 to 1056 in 6882ab9
It's not clear what the downstream effect is. Since .winmd's cannot be referenced by modern .NET projects anyway - the build errors out in the
CheckForUnsupportedWinMDReferences
task - it is possible that this part of Core RAR may be deleted.Versions & Configurations
MSBuild version 17.6.0-preview-23174-01+e7de13307 for .NET
The text was updated successfully, but these errors were encountered: