[Bug]: Terminal logger formatting issue when displaying running targets #8781
Comments
vitek-karas
added
bug
needs-triage
|
This may already be solved with nightlies - we had a width-calculation issue that has been fixed. Can you try to reproduce with preview5 nightlies if you get a chance? |
|
Will see - I can't build the runtime with a preview SDK (well, I could but it's rather complicated) One more question: Will we fix this to show humanly readable duration - as in |
|
I suppose we could - but if we leave it in seconds isn't that motivation for the runtime team to make their build faster? (I kid, of course :) ) |
|
Do you want me to file a separate issue? I would love to be able to build runtime in less than 60 seconds, maybe the new msbuild can make that happen ;-) |
|
I went ahead and created a new issue from your comment/request. |
|
I don't think this is solved yet--I believe I messed up truncation-to-fit-in-window when I colorized TF in #8715. |
AR-May
added
Area: Terminal Logger
The root cause of dotnet#8781 is that the optimize-output-by-skipping- identical-characters logic is not aware of escape sequences, so it goes horribly awry when the replacing line differs after the first escape sequence. Instead, apply the previous logic only if there are no escape sequences; if there are, replace the entire line. If this proves to cause too much flicker or perform slowly, we could implement escape-sequence-aware truncation, length, and comparison, but we can wait for feedback to that effect.
|
Should be fixed by #8907. |
Issue Description
I tried to add
/tlto the build in dotnet/runtime repo. For the most part it works great - I like this.But in some cases the "active" targets (the lines which are updating with times) get mangled a little bit:
This is on Windows, running in Windows Terminal under powershell (.NET 7 pwsh).
Steps to Reproduce
Run something like:
.\build.cmd Clr+Libs /tlin dotnet/runtime repo.Expected Behavior
Each target shows exactly one time.
Actual Behavior
Some targets sometimes show the time twice (with only the second one updating)
Analysis
No response
Versions & Configurations
No response
The text was updated successfully, but these errors were encountered: