-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BinFmt] Custom BuildEventArgs de/serialization #8823
Labels
Comments
This was referenced Jun 1, 2023
Discussed with @rokonec:
|
Additional thoughts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Background
#6215
This subitem is focused on https://github.com/dotnet/msbuild/blob/main/src/Shared/LogMessagePacketBase.cs#L377
Suggested approach
Define custom build event type with de/serialization methods similar to #8779 (however without any type hierarchy/ overloading/ reflection etc - just single type and bag of strings), allow only such custom events - unles opted-out via changewave
Seal our BuildEventArgs hierarchy - to prevent subclasing (handling of subclasses would require registration of those during startup of nodes)
The text was updated successfully, but these errors were encountered: