Deprecate binfmt in build event args #8917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was lots of dead code which makes it appear as if ExternalProject*EventArgs are properly custom serialized, but in reality these were treated as CustomEvent with TranslateDotNet generic binary formatter.
JanKrivanek
reviewed
Jun 21, 2023
JanKrivanek
requested changes
Jun 21, 2023
JanKrivanek
approved these changes
Jun 23, 2023
…ps://github.com/rokonec/msbuild into rokonec/8823-deprecate-binfmt-in-BuildEventArgs
|
@rainersigwald - the warnings now apply only for core - should we mark this as candidate for 17.7 payload? |
JanKrivanek
reviewed
Jul 10, 2023
JanKrivanek
reviewed
Jul 10, 2023
JanKrivanek
reviewed
Jul 25, 2023
JanKrivanek
reviewed
Jul 26, 2023
Closed
3 tasks
…ps://github.com/rokonec/msbuild into rokonec/8823-deprecate-binfmt-in-BuildEventArgs
JanKrivanek
reviewed
Jul 27, 2023
There was a problem hiding this comment.
Couple comments for @YuliiaKovalova
Plus we need to add ability (can be default behavior of the warning mode) of dropping the violating events - otherwise those new tests will start crashing as soon as we remove the temporary EnableUnsafeBinaryFormatterSerialization
Otherwise looks goot to go!
4 tasks
ladipro
reviewed
Aug 7, 2023
Co-authored-by: Ladi Prosek <ladi.prosek@gmail.com>
ladipro
approved these changes
Aug 9, 2023
|
[celebrate] Yuliia Kovalova reacted to your message:
…________________________________
From: Roman Konecny ***@***.***>
Sent: Wednesday, August 9, 2023 2:58:17 PM
To: dotnet/msbuild ***@***.***>
Cc: Yuliia Kovalova ***@***.***>; Mention ***@***.***>
Subject: Re: [dotnet/msbuild] Deprecate binfmt in build event args (PR #8917)
Merged #8917<#8917> into main.
—
Reply to this email directly, view it on GitHub<#8917 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWYM53TT7HZV7FYZUFSA6BLXUOQQTANCNFSM6AAAAAAZNFKUQE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
rainersigwald
pushed a commit
that referenced
this pull request
Oct 26, 2023
Fixes #9220 CustomBuildEventArgs is deprecated. Users are advised to use ExtendedCustomBuildEventArgs instead. See #8917 The comment change results in a public-facing doc change at https://learn.microsoft.com/en-us/dotnet/api/microsoft.build.framework.custombuildeventargs?view=msbuild-17-netcore The new Remarks section includes a link to a public-facing doc that explains the change: https://learn.microsoft.com/en-us/dotnet/core/compatibility/sdk/8.0/custombuildeventargs
| PropertyReassignmentEventArgs propReassign = new("prop", "prevValue", "newValue", "loc", "message", "help", "sender", MessageImportance.Normal); | ||
| ResponseFileUsedEventArgs responseFileUsed = new("path"); | ||
| UninitializedPropertyReadEventArgs uninitializedPropertyRead = new("prop", "message", "help", "sender", MessageImportance.Normal); | ||
| EnvironmentVariableReadEventArgs environmentVariableRead = new("env", "message", "help", "sender", MessageImportance.Normal); |
There was a problem hiding this comment.
I'm not seeing ProjectImportedEventArgs here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8823 and #9008
Context
BinaryFormat deprecations is forcing us to us drop support of CustomEventArgs derived from EventArgs as those are serialized by omnipotent-but-unsecure BinaryFormatter.
Changes Made
Testing
Notes