Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BinFmt] Rework/Remove unit tests using BinaryFormatter #8925

Closed
JanKrivanek opened this issue Jun 20, 2023 · 1 comment · Fixed by #9126
Closed

[BinFmt] Rework/Remove unit tests using BinaryFormatter #8925

JanKrivanek opened this issue Jun 20, 2023 · 1 comment · Fixed by #9126

Comments

@JanKrivanek
Copy link
Member

JanKrivanek commented Jun 20, 2023

Background

#6215
Similar (and can be taken together with) #8924
This subitem is focused on unit tests calling using BinaryFormatter:

Since this is non-shipping code, it's not a priority. However it should be easy to get rid of those and hence make usages of BinaryFormatter in our code base scope to the necessary places (e.g. GenerateResource task)`

Suggested approach

Unit tests testing exceptions and EventArgs serialization should be moved to the new serialization mechanisms for those (#8786, #8917), or delete if duplicate with unittests introduced as part of those new serialization mechanisms, or removed if serializing other types (as those should not currently use BinaryFormatter for de/serialization).

@JanKrivanek
Copy link
Member Author

Marking this for August sprint - since this is blocking removal of EnableUnsafeBinaryFormatterSerialization that should be only temporary in our code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants