Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BinFmt] Rework/Remove unit tests using TranslateDotNet #8924

Closed
JanKrivanek opened this issue Jun 20, 2023 · 0 comments · Fixed by #9017
Closed

[BinFmt] Rework/Remove unit tests using TranslateDotNet #8924

JanKrivanek opened this issue Jun 20, 2023 · 0 comments · Fixed by #9017

Comments

@JanKrivanek
Copy link
Member

JanKrivanek commented Jun 20, 2023

Background

#6215
This subitem is focused on unit tests calling TranslateDotNet (to test de/serialization of exceptions and ProfilerResult)
Since this is non-shipping code, it's not a priority. However it should be easy to get rid of it and so completely remove TranslateDotnet

Suggested approach

Unit tests testing exceptions serialization should be moved to the new exception serialization mechanism (#8786), or removed if redundand
ProfilerResult - most likely just remove, as this most likely uses only ITranslatable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants