Removing dead code unit tests and BinFmt enablement #9126
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8925
Context
Following types serialization is no more facilitated by BinFmt - so removing associated unit tests:
InvalidProjectFileException
- allBuildExceptionBase
exceptions tested viaTestSerializationOfBuildExceptions
; plusInvalidProjectFileException
has it's own test:TestInvalidProjectFileException_NestedWithStack
LoggerException
- same as aboveProjectStartedEventArgs
- serialized via translatable onlyAssemblyName_Ex
- serialized via translatable only. The edited test file already contained tests for both types of serializationCopyOnWriteDictionary
- not custom serialized on any codepath (possibly only viaTranslateDictionary
takingIDictionary
)Changes Made
Appart from removing serialization tests of above mentioned types - removed the
EnableUnsafeBinaryFormatterSerialization
which was needed just because of those tests