Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Allow MSBuild to use BinaryFormatter" #34402

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

JanKrivanek
Copy link
Member

Reverts #33227

Context

The BinaryFormatter was opted-in as a workaround for dotnet/msbuild#8786 - that one is fixed and merged now.
All other tracked outstanding MSBuild dependencies on BinaryFormatter should not be of concern for NET (just NetFramework).

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Aug 2, 2023
@JanKrivanek JanKrivanek requested a review from baronfel August 2, 2023 13:18
@baronfel
Copy link
Member

baronfel commented Aug 2, 2023

@JanKrivanek with this change, are we totally done for .NET MSBuild for .NET 8 with regards to BinaryFormatter? If so, that's great news!

Copy link
Member

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@JanKrivanek
Copy link
Member Author

@JanKrivanek with this change, are we totally done for .NET MSBuild for .NET 8 with regards to BinaryFormatter? If so, that's great news!

2 more subtopics still in flight - however very likely with marginal to no impact:

Rest of the work is mostly cleaning unit tests, preparing for Net Framework BinFmt derecation, facilitating documentation/communication

@JanKrivanek
Copy link
Member Author

Marging - the outstanding msbuild changes are merged and inserted (or about to be inserted):

@JanKrivanek JanKrivanek merged commit 6e5c962 into main Aug 14, 2023
@JanKrivanek JanKrivanek deleted the revert-33227-let-msbuild-binary-format branch August 14, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants