Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Allow MSBuild to use BinaryFormatter" #34402

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Revert "Allow MSBuild to use BinaryFormatter" #34402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions src/Layout/redist/targets/GenerateLayout.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,9 +438,6 @@
<PropertyGroup>
<ReplacementPattern>"version": ".*"</ReplacementPattern>
<ReplacementString>"version": "$(MicrosoftNETCoreAppRuntimePackageVersion)"</ReplacementString>

<DisabledBinaryFormatterPattern>"System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization": false</DisabledBinaryFormatterPattern>
<EnableBinaryFormatterString>"System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization": true</EnableBinaryFormatterString>
</PropertyGroup>
<ItemGroup>
<!-- Exclude F# from retargeting: https://github.com/dotnet/toolset/issues/2866 -->
Expand All @@ -456,14 +453,6 @@
ReplacementPatterns="$(ReplacementPattern)"
ReplacementStrings="$(ReplacementString)" />

<!-- Work around https://github.com/dotnet/msbuild/issues/6215 by opting back into net7 behavior -->
<ReplaceFileContents
InputFiles="@(ToolRuntimeConfigPath)"
DestinationFiles="@(ToolRuntimeConfigPath)"
ReplacementPatterns="$(DisabledBinaryFormatterPattern)"
ReplacementStrings="$(EnableBinaryFormatterString)"
Condition=" '%(ToolRuntimeConfigPath.FileName)' == 'MSBuild.runtimeconfig'" />

<Move
SourceFiles="@(MSBuild15Items)"
DestinationFiles="@(MSBuild15Items -> '$(OutputPath)/Current/%(RecursiveDir)%(Filename)%(Extension)')" />
Expand Down