Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BinFmt] Support extended messages in binary log and binary viewer #9091

Closed
4 tasks done
Tracked by #6215
rokonec opened this issue Aug 1, 2023 · 0 comments · Fixed by #9198
Closed
4 tasks done
Tracked by #6215

[BinFmt] Support extended messages in binary log and binary viewer #9091

rokonec opened this issue Aug 1, 2023 · 0 comments · Fixed by #9198
Assignees
@rokonec
Labels
iteration:2023August Iteration:2023September triaged

Comments

@rokonec
Copy link
Member

rokonec commented Aug 1, 2023 •
edited
Loading

#8917 will introduce new internal EventArgs Extended*EventArgs
In context of PR such events are stored in binary log as existing corresponding non extended *EventArgs.

As there is certain value in showing exteneded event data in binary log we need to:

  • create new binary log events
  • de/ser those
  • bump up FileFormat
  • facilitate updating binary log viewer to support those
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rokonec rokonec

Labels
iteration:2023August Iteration:2023September triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Extended messages data to binary log rokonec/msbuild
2 participants
@rokonec @AR-May