-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Traversal targets for cross-targeting #1018
Changes from all commits
644ce2c
867523f
a3ed352
7930d2e
a52aa1f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,6 +17,15 @@ Copyright (C) Microsoft Corporation. All rights reserved. | |
|
||
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
<!-- | ||
We are doing a cross-targeting build if there is no list of target frameworks specified | ||
nor is there a current target framework being built individually. In that case, this import is | ||
redirected to Microsoft.Common.CrossTargeting.targets. | ||
--> | ||
<PropertyGroup Condition="'$(TargetFrameworks)' != '' and '$(TargetFramework)' == ''"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If there's only a single target framework specified, then the thing still loops, right? I remember some talk about single target frameworks not doing a loop. Did that change? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. IF the single target framework is specified in TargetFrameworks, then yes it loops. You can also configure yourself as an inner build and we won't loop, but then there should be no TargetFrameworks with an s and this condition works too. |
||
<IsCrossTargetingBuild>true</IsCrossTargetingBuild> | ||
</PropertyGroup> | ||
|
||
<!-- | ||
In VS 2010 SP1 and VS 2012, both supported for asset compatibility, the MSBuild installed | ||
as part of them did not enforce using the local ToolsVersion (4.0) in all cases, but instead | ||
just used whatever ToolsVersion was in the project file if it existed on the machine, and | ||
|
@@ -40,6 +49,11 @@ Copyright (C) Microsoft Corporation. All rights reserved. | |
<CscToolPath Condition="'$(CscToolPath)' == '' and '$(BuildingInsideVisualStudio)' != 'true'">$(MsBuildFrameworkToolsPath)</CscToolPath> | ||
</PropertyGroup> | ||
</When> | ||
<When Condition="'$(IsCrossTargetingBuild)' == 'true'"> | ||
<PropertyGroup> | ||
<CSharpTargetsPath>$(MSBuildToolsPath)\Microsoft.Common.CrossTargeting.targets</CSharpTargetsPath> | ||
</PropertyGroup> | ||
</When> | ||
<Otherwise> | ||
<PropertyGroup> | ||
<CSharpTargetsPath>$(MSBuildToolsPath)\Microsoft.CSharp.CurrentVersion.targets</CSharpTargetsPath> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
<!-- | ||
*********************************************************************************************** | ||
Microsoft.Common.CrossTargeting.targets | ||
|
||
WARNING: DO NOT MODIFY this file unless you are knowledgeable about MSBuild and have | ||
created a backup copy. Incorrect changes to this file will make it | ||
impossible to load or build your projects from the command-line or the IDE. | ||
|
||
Copyright (C) Microsoft Corporation. All rights reserved. | ||
*********************************************************************************************** | ||
--> | ||
|
||
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
<Import Project="$(CoreCrossTargetingTargetsPath)" | ||
Condition="'$(CoreCrossTargetingTargetsPath)' != '' and Exists('$(CoreCrossTargetingTargetsPath)')" /> | ||
</Project> |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -886,12 +886,12 @@ Copyright (C) Microsoft Corporation. All rights reserved. | |
|
||
<Target Name="BuildGenerateSources" DependsOnTargets="BuildGenerateSourcesTraverse;$(BuildGenerateSourcesAction)" /> | ||
|
||
<Target Name="BuildGenerateSourcesTraverse" DependsOnTargets="AssignProjectConfiguration;_SplitProjectReferencesByFileExistence"> | ||
<Target Name="BuildGenerateSourcesTraverse" DependsOnTargets="PrepareProjectReferences"> | ||
<MSBuild | ||
Projects="@(_MSBuildProjectReferenceExistent)" | ||
Targets="BuildGenerateSources" | ||
BuildInParallel="$(BuildInParallel)" | ||
Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform)" | ||
Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform); %(_MSBuildProjectReferenceExistent.SetTargetFramework);" | ||
Condition="'$(BuildPassReferences)' == 'true' and '@(ProjectReferenceWithConfiguration)' != '' and '@(_MSBuildProjectReferenceExistent)' != '' and '%(_MSBuildProjectReferenceExistent.BuildReference)' == 'true'" | ||
ContinueOnError="!$(BuildingProject)" | ||
RemoveProperties="%(_MSBuildProjectReferenceExistent.GlobalPropertiesToRemove)"> | ||
|
@@ -911,12 +911,12 @@ Copyright (C) Microsoft Corporation. All rights reserved. | |
|
||
<Target Name="BuildCompile" DependsOnTargets="BuildCompileTraverse;$(BuildCompileAction)" /> | ||
|
||
<Target Name="BuildCompileTraverse" DependsOnTargets="AssignProjectConfiguration;_SplitProjectReferencesByFileExistence"> | ||
<Target Name="BuildCompileTraverse" DependsOnTargets="PrepareProjectReferences"> | ||
<MSBuild | ||
Projects="@(_MSBuildProjectReferenceExistent)" | ||
Targets="BuildCompile" | ||
BuildInParallel="$(BuildInParallel)" | ||
Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform)" | ||
Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform); %(_MSBuildProjectReferenceExistent.SetTargetFramework)" | ||
Condition="'$(BuildPassReferences)' == 'true' and '@(ProjectReferenceWithConfiguration)' != '' and '@(_MSBuildProjectReferenceExistent)' != '' and '%(_MSBuildProjectReferenceExistent.BuildReference)' == 'true'" | ||
ContinueOnError="!$(BuildingProject)" | ||
RemoveProperties="%(_MSBuildProjectReferenceExistent.GlobalPropertiesToRemove)"> | ||
|
@@ -936,12 +936,12 @@ Copyright (C) Microsoft Corporation. All rights reserved. | |
|
||
<Target Name="BuildLink" DependsOnTargets="BuildLinkTraverse;$(BuildLinkAction)" /> | ||
|
||
<Target Name="BuildLinkTraverse" DependsOnTargets="AssignProjectConfiguration;_SplitProjectReferencesByFileExistence" > | ||
<Target Name="BuildLinkTraverse" DependsOnTargets="PrepareProjectReferences" > | ||
<MSBuild | ||
Projects="@(_MSBuildProjectReferenceExistent)" | ||
Targets="BuildLink" | ||
BuildInParallel="$(BuildInParallel)" | ||
Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform)" | ||
Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform); %(_MSBuildProjectReferenceExistent.SetTargetFramework)" | ||
Condition="'$(BuildPassReferences)' == 'true' and '@(ProjectReferenceWithConfiguration)' != '' and '@(_MSBuildProjectReferenceExistent)' != '' and '%(_MSBuildProjectReferenceExistent.BuildReference)' == 'true'" | ||
ContinueOnError="!$(BuildingProject)" | ||
RemoveProperties="%(_MSBuildProjectReferenceExistent.GlobalPropertiesToRemove)"> | ||
|
@@ -1489,6 +1489,81 @@ Copyright (C) Microsoft Corporation. All rights reserved. | |
|
||
</Target> | ||
|
||
<!-- | ||
==================================================================================== | ||
_GetProjectReferenceTargetFrameworkProperties | ||
|
||
Builds the GetTargetFrameworkProperties target of all existent project references, | ||
passing $(TargetFrameworkMoniker) as $(ReferringTargetFramework) and sets the | ||
SetTargetFramework metadata of the project reference to the value that is returned. | ||
|
||
This allows a cross-targeting project to select how it should be configured to | ||
build against the most appropriate target for the referring target framework. | ||
|
||
====================================================================================== | ||
--> | ||
<Target Name="_GetProjectReferenceTargetFrameworkProperties" Outputs="%(_MSBuildProjectReferenceExistent.Identity)"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Or is it here to batch the target so the loose In reply to: 78624878 [](ancestors = 78624878) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Yes. This whole thing feels messy to me, but I couldn't find a better way to express it. I imagined there would be a nice way to say "invoke this task for each item and put an output value from the task in to metadata for the item", but I couldn't find one. Am I just missing the idiomatic way to do this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not seeing a great option, either. Still poking at a thing or two . . . In reply to: 78629179 [](ancestors = 78629179) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok, I have an approach that allows building the refs in parallel. But I'm not sure it's actually better--it requires adding redundant metadata to <Target Name="b">
<ItemGroup>
<_MSBuildProjectReferenceExistent>
<MSBuildSourceProjectFile>%(FullPath)</MSBuildSourceProjectFile>
</_MSBuildProjectReferenceExistent>
</ItemGroup>
<MSBuild
Projects="@(_MSBuildProjectReferenceExistent)"
Targets="GetTargetFrameworkProperties"
BuildInParallel="$(BuildInParallel)">
<Output TaskParameter="TargetOutputs" ItemName="_ProjectReferenceTargetFrameworkConfiguration" />
</MSBuild>
<ItemGroup>
<_MSBuildProjectReferenceExistent Condition="'%(MSBuildSourceProjectFile)' != '' and '@(_MSBuildProjectReferenceExistent->'%(FullPath)')' == '@(_ProjectReferenceTargetFrameworkConfiguration->'%(MSBuildSourceProjectFile)')'">
<Setting>@(_ProjectReferenceTargetFrameworkConfiguration->'%(Identity)')</Setting>
</_MSBuildProjectReferenceExistent>
<Test Include="@(_MSbuildprojectreferenceexistent)" />
</ItemGroup>
</Target> Salient features:
I'm not sure which use of obscure hard-to-reason-about batching features is better. This way is probably slightly more performant (because of parallelism in the remote builds). @cdmihai @AndyGerlicher @jeffkl --thoughts? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I can't deep-link to the right table item, but it's under
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Got it. I was imagining it was some magic flow, but it's just what's set on TargetOutputs. :) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm having trouble getting things to work with this change. :( Given the time constraint (we want this in today so that the new (hopefully-not-but-potentially-breaking) targets are in Preview 5. Would you be ok iterating on the final pattern here as an immediate follow-up change? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's go with the implementation that works we can adjust later. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, that's fine. |
||
<MSBuild | ||
Projects="%(_MSBuildProjectReferenceExistent.Identity)" | ||
Targets="GetTargetFrameworkProperties" | ||
BuildInParallel="$(BuildInParallel)" | ||
Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform); ReferringTargetFramework=$(TargetFrameworkMoniker)" | ||
ContinueOnError="!$(BuildingProject)" | ||
RemoveProperties="%(_MSBuildProjectReferenceExistent.GlobalPropertiesToRemove)"> | ||
|
||
<Output TaskParameter="TargetOutputs" PropertyName="_ProjectReferenceTargetFrameworkProperties" /> | ||
</MSBuild> | ||
|
||
<ItemGroup> | ||
<_MSBuildProjectReferenceExistent Condition="'%(_MSBuildProjectReferenceExistent.Identity)' == '%(Identity)'"> | ||
<SetTargetFramework>$(_ProjectReferenceTargetFrameworkProperties)</SetTargetFramework> | ||
</_MSBuildProjectReferenceExistent> | ||
</ItemGroup> | ||
|
||
<PropertyGroup> | ||
<_ProjectReferenceTargetFrameworkProperties /> | ||
</PropertyGroup> | ||
</Target> | ||
|
||
<!-- | ||
============================================================ | ||
GetTargetFrameworkProperties | ||
|
||
Overrridden by cross-targeting projects to return the set of | ||
properties (in the form "key1=value1;...keyN=valueN") needed | ||
to build it with the best target for the referring project's | ||
target framework. | ||
|
||
The referring project's $(TargetFrameworkMoniker) is passed | ||
in as $(ReferringTargetFramework) | ||
--> | ||
<Target Name="GetTargetFrameworkProperties" /> | ||
|
||
<!-- | ||
============================================================ | ||
PrepareProjectReferences | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a nice improvement 👍 |
||
|
||
Prepares project references for consumption by other targets. | ||
|
||
[IN] | ||
@(ProjectReference) - The list of project references. | ||
|
||
[OUT] | ||
@(ProjectReferenceWithConfiguration) - Project references with apporpriate metadata | ||
@(_MSBuildProjectReferenceExistent) - Subset of @(ProjectReferenceWithConfiguration) that exist | ||
with added SetTargetFramework metadata for cross-targeting | ||
@(_MSBuildProjectReferenceNonExistent) - Subset of @(ProjectReferenceWithConfiguration) that do not exist | ||
============================================================ | ||
--> | ||
<PropertyGroup> | ||
<PrepareProjectReferencesDependsOn> | ||
AssignProjectConfiguration; | ||
_SplitProjectReferencesByFileExistence; | ||
_GetProjectReferenceTargetFrameworkProperties | ||
</PrepareProjectReferencesDependsOn> | ||
</PropertyGroup> | ||
<Target Name="PrepareProjectReferences" DependsOnTargets="$(PrepareProjectReferencesDependsOn)" /> | ||
|
||
<!-- | ||
============================================================ | ||
ResolveProjectReferences | ||
|
@@ -1516,7 +1591,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. | |
|
||
<Target | ||
Name="ResolveProjectReferences" | ||
DependsOnTargets="AssignProjectConfiguration;_SplitProjectReferencesByFileExistence" | ||
DependsOnTargets="PrepareProjectReferences" | ||
Returns="@(_ResolvedNativeProjectReferencePaths);@(_ResolvedProjectReferencePaths)"> | ||
|
||
<!-- | ||
|
@@ -1531,7 +1606,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. | |
Projects="@(_MSBuildProjectReferenceExistent)" | ||
Targets="GetTargetPath" | ||
BuildInParallel="$(BuildInParallel)" | ||
Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform)" | ||
Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform); %(_MSBuildProjectReferenceExistent.SetTargetFramework)" | ||
Condition="'%(_MSBuildProjectReferenceExistent.BuildReference)' == 'true' and '@(ProjectReferenceWithConfiguration)' != '' and ('$(BuildingInsideVisualStudio)' == 'true' or '$(BuildProjectReferences)' != 'true') and '$(VisualStudioVersion)' != '10.0' and '@(_MSBuildProjectReferenceExistent)' != ''" | ||
ContinueOnError="!$(BuildingProject)" | ||
RemoveProperties="%(_MSBuildProjectReferenceExistent.GlobalPropertiesToRemove)"> | ||
|
@@ -1558,7 +1633,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. | |
Projects="@(_MSBuildProjectReferenceExistent)" | ||
Targets="%(_MSBuildProjectReferenceExistent.Targets);GetTargetPath" | ||
BuildInParallel="$(BuildInParallel)" | ||
Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform)" | ||
Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform); %(_MSBuildProjectReferenceExistent.SetTargetFramework)" | ||
Condition="'%(_MSBuildProjectReferenceExistent.BuildReference)' == 'true' and '@(ProjectReferenceWithConfiguration)' != '' and ('$(BuildingInsideVisualStudio)' == 'true' or '$(BuildProjectReferences)' != 'true') and '$(VisualStudioVersion)' == '10.0' and '@(_MSBuildProjectReferenceExistent)' != ''" | ||
ContinueOnError="!$(BuildingProject)" | ||
RemoveProperties="%(_MSBuildProjectReferenceExistent.GlobalPropertiesToRemove)"> | ||
|
@@ -1575,7 +1650,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. | |
Projects="@(_MSBuildProjectReferenceExistent)" | ||
Targets="%(_MSBuildProjectReferenceExistent.Targets)" | ||
BuildInParallel="$(BuildInParallel)" | ||
Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform)" | ||
Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform); %(_MSBuildProjectReferenceExistent.SetTargetFramework)" | ||
Condition="'%(_MSBuildProjectReferenceExistent.BuildReference)' == 'true' and '@(ProjectReferenceWithConfiguration)' != '' and '$(BuildingInsideVisualStudio)' != 'true' and '$(BuildProjectReferences)' == 'true' and '@(_MSBuildProjectReferenceExistent)' != ''" | ||
ContinueOnError="$(ContinueOnError)" | ||
RemoveProperties="%(_MSBuildProjectReferenceExistent.GlobalPropertiesToRemove)"> | ||
|
@@ -1592,7 +1667,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. | |
Projects="@(_MSBuildProjectReferenceExistent)" | ||
Targets="GetNativeManifest" | ||
BuildInParallel="$(BuildInParallel)" | ||
Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform)" | ||
Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform); %(_MSBuildProjectReferenceExistent.SetTargetFramework)" | ||
Condition="'%(_MSBuildProjectReferenceExistent.BuildReference)' == 'true' and '@(ProjectReferenceWithConfiguration)' != '' and '$(BuildingProject)' == 'true' and '@(_MSBuildProjectReferenceExistent)' != ''" | ||
ContinueOnError="$(ContinueOnError)" | ||
RemoveProperties="%(_MSBuildProjectReferenceExistent.GlobalPropertiesToRemove)"> | ||
|
@@ -2117,10 +2192,10 @@ Copyright (C) Microsoft Corporation. All rights reserved. | |
</ItemGroup> | ||
</Target> | ||
|
||
<Target Name="GetReferenceTargetPlatformMonikers" DependsOnTargets="AssignProjectConfiguration;_SplitProjectReferencesByFileExistence"> | ||
<Target Name="GetReferenceTargetPlatformMonikers" DependsOnTargets="PrepareProjectReferences"> | ||
<MSBuild | ||
Projects="@(_MSBuildProjectReferenceExistent)" | ||
Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform)" | ||
Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform); %(_MSBuildProjectReferenceExistent.SetTargetFramework)" | ||
Targets="GetTargetPathWithTargetPlatformMoniker" | ||
BuildInParallel="$(BuildInParallel)" | ||
ContinueOnError="!$(BuildingProject)" | ||
|
@@ -4012,7 +4087,8 @@ Copyright (C) Microsoft Corporation. All rights reserved. | |
<PropertyGroup> | ||
<GetCopyToOutputDirectoryItemsDependsOn> | ||
AssignTargetPaths; | ||
_SplitProjectReferencesByFileExistence | ||
_SplitProjectReferencesByFileExistence; | ||
_GetProjectReferenceTargetFrameworkProperties | ||
</GetCopyToOutputDirectoryItemsDependsOn> | ||
</PropertyGroup> | ||
<Target | ||
|
@@ -4036,7 +4112,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. | |
Projects="@(_MSBuildProjectReferenceExistent)" | ||
Targets="GetCopyToOutputDirectoryItems" | ||
BuildInParallel="$(BuildInParallel)" | ||
Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform)" | ||
Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform); %(_MSBuildProjectReferenceExistent.SetTargetFramework)" | ||
Condition="'@(_MSBuildProjectReferenceExistent)' != '' and '$(_GetChildProjectCopyToOutputDirectoryItems)' == 'true' and '%(_MSBuildProjectReferenceExistent.Private)' != 'false' and '$(UseCommonOutputDirectory)' != 'true'" | ||
ContinueOnError="$(ContinueOnError)" | ||
RemoveProperties="%(_MSBuildProjectReferenceExistent.GlobalPropertiesToRemove)"> | ||
|
@@ -4554,7 +4630,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. | |
--> | ||
<Target | ||
Name="CleanReferencedProjects" | ||
DependsOnTargets="AssignProjectConfiguration; _SplitProjectReferencesByFileExistence"> | ||
DependsOnTargets="PrepareProjectReferences"> | ||
|
||
<!-- | ||
When building the project directly from the command-line, clean those referenced projects | ||
|
@@ -4564,7 +4640,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. | |
<MSBuild | ||
Projects="@(_MSBuildProjectReferenceExistent)" | ||
Targets="Clean" | ||
Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform)" | ||
Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform); %(_MSBuildProjectReferenceExistent.SetTargetFramework)" | ||
BuildInParallel="$(BuildInParallel)" | ||
Condition="'$(BuildingInsideVisualStudio)' != 'true' and '$(BuildProjectReferences)' == 'true' and '@(_MSBuildProjectReferenceExistent)' != ''" | ||
ContinueOnError="$(ContinueOnError)" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I right that this needs to be defined in whatever is the top-level import, because the goal is to short-circuit most of the build logic for the outer build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct.