Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert Emit eval props if requested by any sink (#10243) #10447

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Revert Emit eval props if requested by any sink (#10243) #10447

merged 2 commits into from
Aug 2, 2024

Conversation

JanKrivanek
Copy link
Member

@JanKrivanek JanKrivanek commented Jul 26, 2024 •
edited
Loading

Fixes https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_git/VS/pullRequest/567354#1721971513

Context

#10243 introduced proper populating of eval props based on Loggers requests - this however can lead to props being populated on both - ProjectStartedEventArgs and EvaluationProjectFinishedEventArgs - which leads to higher allocations. We have couple options how to proceed:

  • Accept the allocations increase (and close this PR)
  • Revert the previous changes - however this will lead to 'enlightened' loggers missing data (if old logger ius present) - including BuildCheck going forward
  • Adjust changes by populating only on EvaluationProjectFinishedEventArgs if any loggers requested - leading to breaking not enlightened loggers
  • Go through all the Logger registrations and initializtions in VS and make sure they are 'enlightened' (<--- trying this right now)

@JanKrivanek
Copy link
Member Author

Exp insertion: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/567559

@f-alizada f-alizada marked this pull request as ready for review August 2, 2024 06:33
f-alizada
f-alizada approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@f-alizada f-alizada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's revert the change and investigate later per:
https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems/edit/2173921

@f-alizada f-alizada requested a review from a team August 2, 2024 06:48
@f-alizada f-alizada merged commit bd46115 into dotnet:main Aug 2, 2024
10 checks passed
JanKrivanek added a commit that referenced this pull request Aug 12, 2024
@JanKrivanek
Revert "Revert Emit eval props if requested by any sink (#10243) (#10447
7aeeca8 
)"

This reverts commit bd46115.
@JanKrivanek JanKrivanek mentioned this pull request Aug 12, 2024
Merged
JanKrivanek added a commit that referenced this pull request Aug 15, 2024
@JanKrivanek
Revert "Revert Emit eval props if requested by any sink (#10243)" (#1…
befaec7 
…0508)

* Revert "Revert Emit eval props if requested by any sink (#10243) (#10447)"

This reverts commit bd46115.

* Prevent NullLogger to request eval props

* Remove extra newline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-alizada f-alizada f-alizada approved these changes

@AR-May AR-May AR-May approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JanKrivanek @AR-May @f-alizada