Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests only] Refactor PropertiesUsageAnalyzerTest #10511

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

JanKrivanek
Copy link
Member

Context

Improves the PrepareSampleProjectsAndConfig so that it can be used by tests using different assets. And then used the helper for PropertiesUsageAnalyzerTest

Changes Made

  • Refactored PrepareSampleProjectsAndConfig to accept projectFile and supplementalAssetNames as parameters.
  • Refactored calling tests
  • Extracted the asset file from PropertiesUsageAnalyzerTest
  • Renamed the asset files so that their naming is in line with the naming during testing

Testing

Those are the actual tests

@JanKrivanek JanKrivanek changed the title Proto/improve props tests [Tests only] Refactor PropertiesUsageAnalyzerTest Aug 13, 2024
@JanKrivanek JanKrivanek merged commit 3b1da00 into main Aug 15, 2024
10 checks passed
@JanKrivanek JanKrivanek deleted the proto/improve-props-tests branch August 15, 2024 15:45
@JanKrivanek JanKrivanek self-assigned this Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants