Short circuit repetitive BuildManager.Dispose calls #10690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanKrivanek
changed the title
YuliiaKovalova
approved these changes
Sep 30, 2024
maridematte
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10260
Context
The
BuildManager.Disposewas idempotent, but it wasn't very clear - needed code archeology, plus was easy to break.Let's make it more clear.
Changes Made
Changed just 2 lines:
disposingand_disposedcheck before lock (performing first the cheaper one on local parameter)_disposedafter entering the lockRest of the displayed diff is caused by changed indention due to consolidating the 2 checks before locking.