Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SequenceEqual in win32 GetFullPath #10706

Merged

Conversation

rainersigwald
Copy link
Member

This should be slightly more efficient since it's vectorizable.

This should be slightly more efficient since it's vectorizable.
@MichalPavlik
Copy link
Member

Some constructs are not supported in net35 (MSBuildTaskHost uses this file). I'm afraid a new #if will be required :(

@rainersigwald
Copy link
Member Author

Fixed by replacing the body of the existing function, under an ifdef.

*extremely deep sigh*

@YuliiaKovalova YuliiaKovalova merged commit c034fa1 into dotnet:main Oct 2, 2024
10 checks passed
@rainersigwald rainersigwald deleted the sequenceequal-windows-getfullpath branch October 2, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants