add binlog serialization for BuildCanceledEventArgs #10755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix typo in other test class, add tests
rainersigwald
approved these changes
Oct 7, 2024
YuliiaKovalova
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10244
Context
BuildCanceledEventArgs was added in #10055 but the serialization was missing, this PR adds it
Changes Made
implement the serialization in the same manner as for BuildSubmissionStarted event in #10424
Testing
Unit tests
Notes
Adding support for this to MSBuild Structured Log Viewer PR KirillOsenkov/MSBuildStructuredLog#824
also fixed a typo in BuildSubmissionStartedEventArgs_Tests