Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with langversion preview #10829

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Fix build with langversion preview #10829

merged 3 commits into from
Oct 17, 2024

Conversation

kasperk81
Copy link
Contributor

@kasperk81 kasperk81 commented Oct 16, 2024

/vmr/src/msbuild/src/Build/Evaluation/Profiler/EvaluationLocationPrettyPrinterBase.cs(78,24): error CS0121: The call is ambiguous between the following methods or properties: 'string.Join(string?, params ReadOnlySpan<object?>)' and 'string.Join(string?, params ReadOnlySpan<string?>)' [/vmr/src/msbuild/src/Build/Microsoft.Build.csproj::TargetFramework=net9.0]

pr https://github.com/dotnet/sdk/pull/44011/checks?check_run_id=31628922599
build https://dev.azure.com/dnceng-public/public/_build/results?buildId=844822&view=logs&jobId=f0f4e1eb-2872-579b-17f7-75dc26fbb285&j=f0f4e1eb-2872-579b-17f7-75dc26fbb285&t=e5ca527a-fe4f-597c-4330-d9b726220892

@kasperk81
Copy link
Contributor Author

@surayya-MS can you please merge this to unblock sdk codeflow? dotnet/sdk#44011

@surayya-MS
Copy link
Member

surayya-MS commented Oct 17, 2024

@surayya-MS can you please merge this to unblock sdk codeflow? dotnet/sdk#44011

sure, since it's approved

@surayya-MS surayya-MS merged commit bfa1fdd into dotnet:main Oct 17, 2024
10 checks passed
@kasperk81 kasperk81 deleted the patch-2 branch October 17, 2024 07:00
@kasperk81
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants