Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging behavior doc #10859

Merged
merged 7 commits into from
Dec 11, 2024
Merged

Logging behavior doc #10859

merged 7 commits into from
Dec 11, 2024

Conversation

maridematte
Copy link
Contributor

Fixes #10676

Context

There has some confusion about which logs display what type of message. This is to clarify what is to be expected from each logger and verbosity.

Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very helpful!!

documentation/Logging-behaviour.md Outdated Show resolved Hide resolved
documentation/Logging-behaviour.md Outdated Show resolved Hide resolved
documentation/Logging-behaviour.md Outdated Show resolved Hide resolved
documentation/Logging-behaviour.md Outdated Show resolved Hide resolved
documentation/Logging-behaviour.md Outdated Show resolved Hide resolved
documentation/Logging-behaviour.md Outdated Show resolved Hide resolved
documentation/Logging-behaviour.md Outdated Show resolved Hide resolved
@maridematte maridematte marked this pull request as ready for review November 11, 2024 13:25
documentation/Logging-behaviour.md Outdated Show resolved Hide resolved
documentation/Logging-behaviour.md Outdated Show resolved Hide resolved
Copy link
Member

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a bit of wording suggestions, but overall I'm very happy with having a centralized place to put logger comparisons!

@JanProvaznik
Copy link
Member

nit: behaviour is standard British English, to be consistent we should use American (behavior)

@maridematte maridematte changed the title Logging behaviour doc Logging behavior doc Dec 11, 2024
@maridematte maridematte enabled auto-merge (squash) December 11, 2024 13:35
@maridematte maridematte merged commit 5f72fc4 into dotnet:main Dec 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Update docs for clarity about different Logger behaviors
5 participants