Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Run tests even if version is not bumped #11042

Merged

Conversation

JanProvaznik
Copy link
Member

@JanProvaznik JanProvaznik commented Nov 26, 2024

Fixes #11014

Context

Let's run tests even though version is not bumped.

(no effect on main but when future release branches branch from it they'll inherit the change)

backport to vs17.10, vs17.11, vs17.12 where this pipeline step is present

@JanProvaznik JanProvaznik requested a review from a team as a code owner November 26, 2024 17:29
@JanProvaznik JanProvaznik changed the base branch from main to vs17.8 November 26, 2024 17:31
@JanProvaznik JanProvaznik changed the base branch from vs17.8 to main November 26, 2024 17:31
@JanProvaznik JanProvaznik deleted the dev/janpro/unblock-tests-version-bump branch November 26, 2024 17:32
@JanProvaznik JanProvaznik restored the dev/janpro/unblock-tests-version-bump branch November 26, 2024 17:43
@JanProvaznik JanProvaznik reopened this Nov 26, 2024
@JanProvaznik
Copy link
Member Author

/backport to vs17.10

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Started backporting to vs17.10: https://github.com/dotnet/msbuild/actions/runs/12118444247

Copy link
Contributor

github-actions bot commented Dec 2, 2024

@JanProvaznik an error occurred while backporting to vs17.10, please check the run log for details!

Error: @JanProvaznik is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your dotnet team membership visibility is set to Public on https://github.com/orgs/dotnet/people?query=JanProvaznik

@JanProvaznik
Copy link
Member Author

/backport to vs17.10

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Started backporting to vs17.10: https://github.com/dotnet/msbuild/actions/runs/12118482195

@JanProvaznik
Copy link
Member Author

/backport to vs17.11

@JanProvaznik
Copy link
Member Author

/backport to vs17.12

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Started backporting to vs17.11: https://github.com/dotnet/msbuild/actions/runs/12118498258

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Started backporting to vs17.12: https://github.com/dotnet/msbuild/actions/runs/12118499199

@JanProvaznik JanProvaznik merged commit c200be2 into dotnet:main Dec 2, 2024
11 checks passed
@JanProvaznik JanProvaznik deleted the dev/janpro/unblock-tests-version-bump branch December 2, 2024 11:36
JaynieBai pushed a commit that referenced this pull request Dec 3, 2024
JaynieBai pushed a commit that referenced this pull request Dec 3, 2024
JanKrivanek pushed a commit that referenced this pull request Dec 10, 2024
* Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 10000931 (#10267)

* Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 9752299
* Increase VersionPrefix version

---------

Co-authored-by: Jenny Bai <v-jennybai@microsoft.com>

* [17.11] Fix component governance alerts (#10520)

* Resolves CG alerts
---------

Co-authored-by: Rainer Sigwald <raines@microsoft.com>

* Assembly redirect fix (#10624)

* Fixing the assembly redirect

* [vs17.11] Update dependencies from dotnet/arcade (#10654)

* Update dependencies from https://github.com/dotnet/arcade build 20240910.4

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.24311.3 -> To Version 8.0.0-beta.24460.4

* version bump

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Mariana Garces Dematte <magarces@microsoft.com>

* Upgrade system.text.json to 8.0.4 (#10650)

Will address dotnet/sdk#43339 when deployed in VS.

---------

Co-authored-by: Rainer Sigwald <raines@microsoft.com>

* disable loc (#10693)

Part of: #10665

Disabling localization for 17.11.

* [vs17.11] Update dependencies from dotnet/arcade (#10691)

* [vs17.11] Update dependencies from dotnet/arcade (#10793)

* Update dependencies from https://github.com/dotnet/arcade build 20241008.1

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.24475.3 -> To Version 8.0.0-beta.24508.1

* bump the version

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: YuliiaKovalova <95473390+YuliiaKovalova@users.noreply.github.com>

* CG alert cleaning on VS17.11 (#10723)

* Bump Microsoft.IO.Redist to 6.0.1
* Bump version prefix to 17.11.11

* [vs17.11] Update dependencies from dotnet/arcade (#10832)

* [vs17.11] Update dependencies from dotnet/arcade (#10895)

* [vs17.11] Update dependencies from dotnet/arcade (#10990)

* Update dependencies from https://github.com/dotnet/arcade build 20241112.12

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.24525.2 -> To Version 8.0.0-beta.24562.12

* Update VersionPrefix to 17.11.16

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Gang Wang <v-gaw@microsoft.com>

* Update dependencies from https://github.com/dotnet/arcade build 20241120.5

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.24562.12 -> To Version 8.0.0-beta.24570.5

* Update VersionPrefix to 17.11.17

* [vs17.11] Run tests even if version is not bumped (#11060)

Backport of #11042 to vs17.11

* [vs17.11] Backport VS insertion pipeline YMLs (#11064)

Co-authored-by: Jan Provaznik <janprovaznik@microsoft.com>

* Eliminate the unnecessary change from vs17.11

* Remove duplicate version setting for System.Formats.Asn1

* Bump up version prefix to 17.12.18

---------

Co-authored-by: dotnet bot <dotnet-bot@dotnetfoundation.org>
Co-authored-by: Jenny Bai <v-jennybai@microsoft.com>
Co-authored-by: MichalPavlik <michalpavlik@outlook.com>
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Mariana Garces Dematte <magarces@microsoft.com>
Co-authored-by: YuliiaKovalova <95473390+YuliiaKovalova@users.noreply.github.com>
Co-authored-by: Gang Wang <v-gaw@microsoft.com>
Co-authored-by: Surayya Huseyn Zada <114938397+surayya-MS@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jan Provaznik <janprovaznik@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Check Version Bump On Release Branches" shouldn't block normal build+test
3 participants