Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose processes leveraged by BuildManager #11146

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JanKrivanek
Copy link
Member

Fixes #11051

Context

For various hangs detection we need worker processes dumps. Let's unblock VS perf team in enabling automatic collection of worker processes dumps.

Testing

No tests provided.
This is best effort, point in time functionality, that should be used so

FYI @davkean

@JanKrivanek JanKrivanek enabled auto-merge (squash) December 13, 2024 18:52
/// without guarantee of 100% correctness and safety.
/// </summary>
/// <returns>Enumeration of <see cref="Process"/> objects that were valid during the time of call to this function.</returns>
public IEnumerable<Process> GetWorkerProcesses()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we consider leveraging telemetry for this information too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we have it, we surely can :-)

What exact telemetry would you like to collect?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose worker node PIDs via BuildManager API
2 participants