Skip to content

Add null check when iterating through TargetOutputs in terminal logger #11606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YuliiaKovalova merged 1 commit into from
Mar 19, 2025
Merged

Add null check when iterating through TargetOutputs in terminal logger #11606

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Build/Logging/TerminalLogger/TerminalLogger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,15 +808,17 @@ private void TargetFinished(object sender, TargetFinishedEventArgs e)
// For cache plugin projects which result in a cache hit, ensure the output path is set
// to the item spec corresponding to the GetTargetPath target upon completion.
var buildEventContext = e.BuildEventContext;
var targetOutputs = e.TargetOutputs;
if (_restoreContext is null
&& buildEventContext is not null
&& targetOutputs is not null
&& _hasUsedCache
&& e.TargetName == "GetTargetPath"
&& _projects.TryGetValue(new ProjectContext(buildEventContext), out TerminalProjectInfo? project))
{
if (project.IsCachePluginProject)
if (project is not null && project.IsCachePluginProject)
{
foreach (ITaskItem output in e.TargetOutputs)
foreach (ITaskItem output in targetOutputs)
{
project.OutputPath = output.ItemSpec.AsMemory();
break;
Expand Down