Add runtime mismatch validation when Runtime is explicitly specified in custom task #12642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds validation to ensure custom tasks execute out-of-process when a Runtime parameter (e.g., "Net") is explicitly specified but doesn't match the current process runtime. Previously, this required explicit TaskFactory="TaskHostFactory" in the UsingTask declaration.
Key Changes
- Modified type loading logic to check if task host parameters match the current process
- Introduced
isTaskHostParamsMatchCurrentProcparameter to control metadata load context usage - Added end-to-end test validating out-of-process execution with explicit Runtime specification
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Shared/TypeLoader.cs | Added isTaskHostParamsMatchCurrentProc parameter throughout type loading chain to enable runtime mismatch detection |
| src/Build/Instance/TaskFactories/AssemblyTaskFactory.cs | Initialized runtime mismatch detection by comparing task host parameters with current process |
| src/Build.UnitTests/TestAssets/ExampleNetTask/TestNetTaskWithImplicitParams/global.json | Added SDK configuration for test asset to prevent SDK path resolution issues |
| src/Build.UnitTests/TestAssets/ExampleNetTask/TestNetTaskWithImplicitParams/TestNetTaskWithImplicitParams.csproj | Created test project with Runtime="NET" to validate out-of-process execution |
| src/Build.UnitTests/NetTaskHost_E2E_Tests.cs | Added test verifying task executes out-of-process when Runtime is specified without TaskHostFactory |
| src/Build.UnitTests/Microsoft.Build.Engine.UnitTests.csproj | Added reference to new test asset's global.json file |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
rainersigwald
approved these changes
Oct 20, 2025
baronfel
reviewed
Oct 21, 2025
surayya-MS
approved these changes
Oct 21, 2025
This was referenced Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, in order to have Runtime="Net" executed out-of-proc, you must explicitly specify TaskFactory="TaskHostFactory" in the UsingTask element.
Changes Made
Added runtime mismatch validation when Runtime is explicitly specified to omit TaskFactory specification in UsingTask.
Regression
No
Risks
Low — validation logic only affects cases where Runtime is explicitly set.
Testing
Added a dedicated test.