Handle null ProjectFile in InvalidProjectFileException#13179
Merged
ViktorHofer merged 1 commit intomainfrom Feb 3, 2026
Merged
Handle null ProjectFile in InvalidProjectFileException#13179ViktorHofer merged 1 commit intomainfrom
ViktorHofer merged 1 commit intomainfrom
Conversation
The internal InvalidProctFileException constructor accepts an existing InvalidProjectFileException object as a parameter. It passes the ProjectFile property from that passed in object to another constructor that then verifies that projectFile is not null. Whenever an InvalidProjectFileException object is passed in that has a null projectFile (which is possible via the public ctors), an ArgumentNullException gets thrown and hides real errors. The object gets passed to the internal ctor here: https://github.com/dotnet/msbuild/blob/8bd4d54903169f7e515f8a32e20190b340a295c9/src/Build/BackEnd/Components/RequestBuilder/TaskBuilder.cs#L923 Fix this by passing "MSBUILD" as a string in whenever projectFile is null. Fixes #13150
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a bug where InvalidProjectFileException could throw an ArgumentNullException when wrapping another InvalidProjectFileException that has a null ProjectFile property. This issue manifested non-deterministically in production builds, hiding the actual error being reported.
Changes:
- Modified the internal constructor to use null-coalescing operator (
??) to provide "MSBUILD" as a fallback value when the inner exception'sProjectFileis null
MichalPavlik
approved these changes
Feb 3, 2026
Copilot AI
pushed a commit
that referenced
this pull request
Feb 3, 2026
The internal InvalidProctFileException constructor accepts an existing InvalidProjectFileException object as a parameter. It passes the ProjectFile property from that passed in object to another constructor that then verifies that projectFile is not null. Whenever an InvalidProjectFileException object is passed in that has a null projectFile (which is possible via the public ctors), an ArgumentNullException gets thrown and hides real errors. The object gets passed to the internal ctor here: https://github.com/dotnet/msbuild/blob/8bd4d54903169f7e515f8a32e20190b340a295c9/src/Build/BackEnd/Components/RequestBuilder/TaskBuilder.cs#L923 Fix this by passing "MSBUILD" as a string in whenever projectFile is null. Fixes #13150
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The internal InvalidProctFileException constructor accepts an existing InvalidProjectFileException object as a parameter. It passes the ProjectFile property from that passed in object to another constructor that then verifies that projectFile is not null.
Whenever an InvalidProjectFileException object is passed in that has a null projectFile (which is possible via the public ctors), an ArgumentNullException gets thrown and hides real errors.
The object gets passed to the internal ctor here:
msbuild/src/Build/BackEnd/Components/RequestBuilder/TaskBuilder.cs
Line 923 in 8bd4d54
Fix this by passing "MSBUILD" as a string in whenever projectFile is null.
Fixes #13150