Code

Implicit Sdk imports#1403

Code

Merged

rainersigwald merged 30 commits intodotnet:vs15-rc2dotnet/msbuild:vs15-rc2from rainersigwald:sdk-imports-virtual-elementsrainersigwald/msbuild:sdk-imports-virtual-elementsCopy head branch name to clipboardNov 30, 2016

+416-18

Commits

Commits on Nov 30, 2016

• POC of parser-injection approach to imports

  rainersigwald

  committed
  2e08446

  Copy full SHA for 2e08446

• Implicit import element

  rainersigwald

  committed
  f869b51

  Copy full SHA for f869b51

• make implicitness a property of the import element--PP does not work

  rainersigwald

  committed
  b71b619

  Copy full SHA for b71b619

• back to implicit xml element--fixes preprocessor that walks only over the XML tree

  rainersigwald

  committed
  b107746

  Copy full SHA for b107746

• Make Implicit field public so it can be observed from the public OM

  rainersigwald

  committed
  d408ca3

  Copy full SHA for d408ca3

• Disposable TemporaryEnvironment

  rainersigwald

  committed
  7b81fdf

  Copy full SHA for 7b81fdf

• What? you want a TEST?

  rainersigwald

  committed
  ef4b933

  Copy full SHA for ef4b933

• Do not require additional files in CreateFilesInDirectory

  rainersigwald

  committed
  769ce6b

  Copy full SHA for 769ce6b

• Test to verify that editing via the OM doesn't serialize implicit imports (it currently does)

  rainersigwald

  committed
  0aa0ef0

  Copy full SHA for 0aa0ef0

• Use MSBuildSDKsPath environment variable for path to Sdks

  

  dsplaisted

  authored and

  rainersigwald

  committed
  96fd4df

  Copy full SHA for 96fd4df

• Remove implicit elements from XML at Save() time

  rainersigwald

  committed
  e5c9de9

  Copy full SHA for e5c9de9

• Multiple ;-delimited Sdks in Project attribute

  rainersigwald

  committed
  291254d

  Copy full SHA for 291254d

• Use named constant for Sdk attribute

  rainersigwald

  committed
  7419c05

  Copy full SHA for 7419c05

• Allow version specifier in Project Sdk attribute

  Show description for d398f20
  rainersigwald

  committed
  d398f20

  Copy full SHA for d398f20

• [Test Needed] Error on file containing _Implicit attr

  rainersigwald

  committed
  e30f3d3

  Copy full SHA for e30f3d3

• Sdk Preprocessor output test

  rainersigwald

  committed
  350e21b

  Copy full SHA for 350e21b

• Move ProjectSdkImplicitImport tests to own file

  rainersigwald

  committed
  9f11ecf

  Copy full SHA for 9f11ecf

• Use Implicit instead of HasXmlRepresentation

  rainersigwald

  committed
  2fa8e4e

  Copy full SHA for 2fa8e4e

• Implicit -> IsImplicit

  Show description for c085463
  rainersigwald

  committed
  c085463

  Copy full SHA for c085463

• Remove SelectNodes null check (just fail if it goes that wrong)

  rainersigwald

  committed
  4dd1af7

  Copy full SHA for 4dd1af7

• Remove misleading ProjectLocation remark

  rainersigwald

  committed
  61e14a8

  Copy full SHA for 61e14a8

• Preprocess Sdk attr for conditioned imports too

  rainersigwald

  committed
  f9e09eb

  Copy full SHA for f9e09eb

• Add string error for badly-formed Sdk attribute

  rainersigwald

  committed
  b47e0e0

  Copy full SHA for b47e0e0

• Clone() isn't available in Core

  rainersigwald

  committed
  efdb487

  Copy full SHA for efdb487

• Disable GitVersioning in CI to work around dotnet#1409

  rainersigwald

  committed
  d83721a

  Copy full SHA for d83721a

• Default MSBuildSDKsPath location to {tools}\Sdks

  rainersigwald

  committed
  9801c6d

  Copy full SHA for 9801c6d

• Use MSBuildExtensionsPath-equivalent instead of ToolsPath for Sdk parent folder

  rainersigwald

  committed
  94214d3

  Copy full SHA for 94214d3

• Use only 2-element Path.Combine for downlevel compat

  rainersigwald

  committed
  fd8c656

  Copy full SHA for fd8c656

• Error when importing from non-existent SDK

  Show description for b3f22f8
  rainersigwald

  committed
  b3f22f8

  Copy full SHA for b3f22f8

• Fix AddProperty_WithSdk_KeepsSdkAndImplicitImports

  rainersigwald

  committed
  2b5610e

  Copy full SHA for 2b5610e