Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid Xml comment being generated in preprocessor if "--" is in the path to a resolved Sdk #1428

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix invalid Xml comment being generated in preprocessor if "--" is in…
… the path to a resolved Sdk
dsplaisted committed Dec 2, 2016
commit 915a23c1c37eb4c931db15a85dd320853dcdb3af
2 changes: 1 addition & 1 deletion src/XMakeBuildEngine/Evaluation/Preprocessor.cs
Original file line number Diff line number Diff line change
@@ -195,7 +195,7 @@ private void CloneChildrenResolvingImports(XmlNode source, XmlNode destination)
if (((XmlElement)child).GetAttribute(XMakeAttributes.@implicit).Length > 0)
{
importTag =
$" Import of \"{importProject}\" from Sdk \"{importSdk}\" was implied by the {XMakeElements.project} element's {XMakeAttributes.sdk} attribute.";
$" Import of \"{importProject.Replace("--", "__")}\" from Sdk \"{importSdk}\" was implied by the {XMakeElements.project} element's {XMakeAttributes.sdk} attribute.";
}

destination.AppendChild(destinationDocument.CreateComment(