Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build on RHEL 7 #1718

Merged
merged 1 commit into from
Feb 22, 2017
Merged

Fix build on RHEL 7 #1718

merged 1 commit into from
Feb 22, 2017

Conversation

omajid
Copy link
Member

@omajid omajid commented Feb 16, 2017

  • Add detection for rhel.7-x64 runtime id to cibuild.sh
  • Add rhel.7-x64 runtime ids to project.json's with runtime sections

Tested on RHEL 7.3 with a ./cibuild.sh.

@omajid
Fix build on RHEL 7
b1c4802 
- Add detection for rhel.7-x64 runtime id to cibuild.sh
- Add rhel.7-x64 runtime ids to project.json's with runtime sections

Tested on RHEL 7.3
rainersigwald
rainersigwald approved these changes Feb 17, 2017
View reviewed changes
Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I assume this worked on your RHEL 7 machine?

@omajid
Copy link
Member Author

omajid commented Feb 17, 2017

Yes. I tested it (only) on RHEL 7.3.

@rainersigwald
Copy link
Member

@dotnet-bot test Ubuntu16.04 Build for CoreCLR please

(it looks like something convinced the init script that it was running on 16.10? But the machine was named ubuntu1604-20170216-40d4a0 which I assume implies 16.04 . . .)

@borgdylan
Copy link

16.10 support need to be added along with 17.04 as well. Ubuntu 17.04 will be out in April.

@AndyGerlicher
Copy link
Contributor

@dotnet-bot test Ubuntu16.04 Build for CoreCLR please

@omajid
Copy link
Member Author

omajid commented Feb 21, 2017

Is the issue being experience by the builder a general issue or is it a bug in the fix?

@rainersigwald
Copy link
Member

@omajid I don't think it's related to your change; I plan to spend some time today chasing it down. No action needed from you at the moment . . .

@rainersigwald
Copy link
Member

@dotnet-bot test Ubuntu16.04 Build for CoreCLR please

@rainersigwald
Copy link
Member

Looks good. @Microsoft/msbuild-maintainers can I get a second opinion?

@AndyGerlicher AndyGerlicher merged commit 3bf6f95 into dotnet:xplat Feb 22, 2017
@AndyGerlicher
Copy link
Contributor

Thanks! Sorry for the confusion on had build issues not related to this change.

@omajid
Copy link
Member Author

omajid commented Feb 22, 2017

Thanks for accepting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyGerlicher AndyGerlicher AndyGerlicher approved these changes

@rainersigwald rainersigwald rainersigwald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@omajid @rainersigwald @borgdylan @AndyGerlicher @dnfclas