Ref asm bugfixes #2167
Merged
Ref asm bugfixes #2167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated with a fix for #2165 and removal of the UpToDateCheckInputs items (which should be an extremely minor perf boost). |
This item is checked only from the static evaluation of the project, not after RAR runs--so there's no point in fiddling with it during execution.
Fixes #2165 by never putting a reference to metadata in the ReferenceAssembly field in the first place, so it's never there to get emplaced in a new item escaped and mangle things downstream.
rainersigwald
force-pushed
the
feature/resgen-ref-asm
branch
from
36fd82e
to
a7d10f4
Compare
|
Per conversation with @AndyGerlicher, we're going to postpone the non-GenerateResources part of this fix until we can confirm that using ref assemblies is correct with tool owners. The risks are that if it's wrong, we might break all consumers of the winmdexp and lc targets. If we continue with the current state, reference assemblies are less effective in some scenarios. That seems like a good tradeoff at this stage of 15.3. |
AndyGerlicher
approved these changes
Jun 5, 2017
|
Makes sense. Let's keep an open issue? |
2 tasks
AndyGerlicher
approved these changes
Jun 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These look like good places to use ref assemblies if present--but we need to track down owners for the various tools here and confirm that they're correct.
@jcouv