Display an error if an ITaskFactory does not set the TaskType property. #2363
Conversation
If TaskType is null it can cause a NullReferenceException in our code. This change ensures that ITaskFactory implementations return a value for this property. Fixes dotnet#1508
src/Build/Instance/TaskRegistry.cs
Outdated
| @@ -1425,6 +1431,10 @@ private bool GetTaskFactory(TargetLoggingContext targetLoggingContext, ElementLo | |||
| return false; | |||
| } | |||
| } | |||
| catch(InvalidProjectFileException) | |||
| { | |||
| throw; | |||
There was a problem hiding this comment.
The new ProjectErrorUtilities.ThrowInvalidProject() is in a try...catch which wraps the exception again. This new catch is to allow the original exception to be thrown.
There was a problem hiding this comment.
Comment, please :)
I'm also not sure I think it's worth the unique error code for this if the message is good. But it's already done so go with it.
There was a problem hiding this comment.
Okay I've removed the unique error code and thrown an InvalidOperationException so the overall error contains the message
nulltasktype.proj(10,5): error MSB4175: The task factory "Microsoft.Build.UnitTests.BackEnd.TaskRegistry_Tests+NullTaskTypeTaskFactory" could not be loaded from the assembly "D:\msbuild\bin\Debug\AnyCPU\Windows_NT\Output\Microsoft.Build.Engine.UnitTests.dll". The task factory must return a value for the "TaskType" property.
|
@dotnet-bot test Windows_NT Build for CoreCLR please |
src/Build/Instance/TaskRegistry.cs
Outdated
| @@ -1425,6 +1431,10 @@ private bool GetTaskFactory(TargetLoggingContext targetLoggingContext, ElementLo | |||
| return false; | |||
| } | |||
| } | |||
| catch(InvalidProjectFileException) | |||
| { | |||
| throw; | |||
There was a problem hiding this comment.
Comment, please :)
I'm also not sure I think it's worth the unique error code for this if the message is good. But it's already done so go with it.
If TaskType is null it can cause a NullReferenceException in our code. This change ensures that ITaskFactory implementations return a value for this property.
Fixes #1508