Avoid RuntimeInformation on full sln parse #3283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We started (transitively) requiring System.Runtime.InteropServices.RuntimeInformation when using `SolutionFile.Parse` after dotnet#2963. The assembly-level dependency is longstanding. But since it wasn't needed in NuGet's calling pattern, many versions of NuGet are broken on older (pre-4.7.1) .NET Frameworks. Work around the assembly load by avoiding the adjustment filepath on full-Framework MSBuild (where it's not necessary anyway). Closes dotnet#3282.
jeffkl
approved these changes
May 9, 2018
cdmihai
approved these changes
May 9, 2018
AndyGerlicher
approved these changes
May 11, 2018
|
Approved for VS servicing and .NET Core SDK 2.1.300. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We started (transitively) requiring
System.Runtime.InteropServices.RuntimeInformation when using
SolutionFile.Parseafter #2963. The assembly-level dependency islongstanding. But since it wasn't needed in NuGet's calling pattern,
many versions of NuGet are broken on older (pre-4.7.1) .NET Frameworks.
Work around the assembly load by avoiding the adjustment filepath on
full-Framework MSBuild (where it's not necessary anyway).
Closes #3282.