Create instructions on how to test private bits #5818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used for testing private bits in Visual Studio.
documentation/wiki/Building-Testing-and-Debugging-on-.Net-Core-MSBuild.md
Outdated
Show resolved
Hide resolved
Forgind
commented
Oct 23, 2020
Forgind
commented
Oct 23, 2020
documentation/Deploy-MSBuild.md
Outdated
|
|
||
| - Build MSBuild with the changes you want using `build.cmd /p:CreateBootstrap=true`. | ||
| - In an administrator powershell window, navigate to the msbuild folder. | ||
| - Run `scripts\Deploy-MSBuild.ps1 -destination "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Current\Bin" -configuration Debug`. |
There was a problem hiding this comment.
I'm undecided about putting them inline like this, partially because there are reasons to use -configuration Release, but I like showing all the options inline. Maybe -configuration then specify what that means below?
There was a problem hiding this comment.
Isn't that what I did? I specify parameters for both here and explain how they might need to be changed below.
There was a problem hiding this comment.
Markdown edited out part of my comment 😮
-configuration <configuration> and explain what <configuration> means below is what I meant to say.
There was a problem hiding this comment.
Ahh. Yeah . . . that is much clearer :)
documentation/wiki/Building-Testing-and-Debugging-on-.Net-Core-MSBuild.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Forgind <Forgind@users.noreply.github.com>
…failure I'm not totally sure why this fails sometimes on Mono. But it does, and it's super annoying. Works around dotnet#5506.
…nto deploy-msbuild
|
I think this looks good to me, now! (Minus Exec_Tests pollution.) |
…Ignored failure" This reverts commit bc9d31a.
rainersigwald
approved these changes
Oct 23, 2020
rainersigwald
added
the
merge-when-branch-open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used for testing private bits in Visual Studio.