Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆ Update a bunch of package references #5910

Closed
wants to merge 14 commits into from

Conversation

rainersigwald
Copy link
Member

Update a ton of our package references to the latest available version.

I recommend going commit-by-commit on this one.

@rainersigwald rainersigwald added the Area: Our Own Build Problems affecting the build or build infrastructure of the MSBuild repo itself. label Nov 24, 2020
@rainersigwald rainersigwald marked this pull request as draft November 24, 2020 22:56
@rainersigwald rainersigwald marked this pull request as ready for review November 30, 2020 16:43
@Forgind
Copy link
Member

Forgind commented Nov 30, 2020

I'm not at all opposed to this, but would you mind throwing it in an exp branch (or I can if you'd prefer)? I have a feeling this will cause ngen problems, and if so, it would be good to know what to do before merging.

@rainersigwald rainersigwald marked this pull request as draft December 4, 2020 17:07
@rainersigwald
Copy link
Member Author

VS insertions are blocked on a bunch of upgrades there, but I think dotnet/roslyn#49789 and its linked VS pr will take care of a bunch of that (so thanks, @AArnott!).

@AArnott
Copy link
Contributor

AArnott commented Dec 8, 2020

@rainersigwald You are updating some packages that I didn't look at in the VS repo. So if you're taking those dependencies in the devenv.exe process, we may need to update more platform DLLs for this to work.

Base automatically changed from master to main March 15, 2021 20:09
Forgind and others added 14 commits April 5, 2021 12:34
Add the behavior improvements from dotnet#6312 to the 16.10 changewave since
they cause failures in cases that didn't fail before.
…tnet#6334)

MSBuild redistributes System.Memory but does not binding redirect it. This causes the QB cache plugin to fail (qb.exe works because it has binding redirects, but the plugin fails because it's a dll and dlls don't have binding redirects).
Both MSBuild and VS ship with System.Memory 4.0.1.1 so this should not have any negative consequences.
Add explicit reference to Microsoft.DotNet.PlatformAbstractions because
it's no longer referenced by Microsoft.Extensions.DependencyModel. Use a
version that matches the 2.1 that we use for bootstrapping.
It looks like new CodeDOM doesn't include this any more: dotnet/corefx#35458
@rainersigwald rainersigwald changed the base branch from main to vs17.0 April 27, 2021 17:14
@Forgind
Copy link
Member

Forgind commented Jun 2, 2021

Since it's been almost 7 months, have the platform DLLs AArnott mentioned been updated? If so, other than conflicts, is there anything we need before this can go in?

@rainersigwald
Copy link
Member Author

No, they haven't. Who knows when we'll get back to this so let's just get rid of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Our Own Build Problems affecting the build or build infrastructure of the MSBuild repo itself.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants