Allow redundant specification of MSBuild assemblies in inline tasks #5975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmeschter
approved these changes
Dec 17, 2020
Forgind
approved these changes
Dec 18, 2020
Forgind
reviewed
Dec 18, 2020
ladipro
approved these changes
Dec 18, 2020
rainersigwald
force-pushed
the
amd64-inline-tasks
branch
from
84643d8 to
f3055a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5822 by filtering out the default MSBuild assemblies from the UsingTask list.
9bfc622 is the real work but there were a bunch of refactorings to make that clear. I recommend going commit-by-commit.