made CircularDependencyExcpetion class public

[tflynt91]

Closes #5811

[benvillalobos]

@tflynt91 could you provide context for this change in the description?

[benvillalobos]

##[error] After building, there are changed files. Please build locally and include these changes in your pull request. Can you run build.cmd and push up any changes?

[tflynt91]

Will do!

[dnfadmin]

All CLA requirements met.

[dnfadmin]

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ tflynt91 sign now
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[benvillalobos]

The last blocker is to sign the CLA. Otherwise, LGTM!

[tflynt91]

great thanks! I believe I signed it but maybe the status is still pending

[rainersigwald]

Thanks! Just a couple of nitpicks to address.

I don't know why there are two comments about the CLA but one of them and the check are happy so I believe you signed it :)

[rainersigwald]

Is this change necessary? I think it's ok for this ideally-unused constructor to continue to be protected.

[rainersigwald]

We haven't exposed this namespace before, so I think we should move the exception into the Microsoft.Build.Exceptions namespace where the others are:

msbuild/ref/Microsoft.Build/net/Microsoft.Build.cs

Lines 887 to 890 in dcf8be3

	namespace Microsoft.Build.Exceptions
	{
	public partial class BuildAbortedException : System.Exception
	{

Can you change the namespace in CircularDependencyException.cs?

[tflynt91]

sounds good! I think keeping it protected was causing some error preventing it from building. The build worked on my end, I think the namespace change might resolve that, so I changed it back to protected.

[rainersigwald]

Looks great. Thank you!