-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused files from the repo #6158
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forgind
approved these changes
Feb 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
This is a part of XMake project in VS repo. This is not used here in this MSBuild repo.
Replaced with Azure Pipelines and Arcade Sdk
No longer needed. Replaced with dotnet tool.
No longer needed. Replaced with dotnet tool.
This batch file was used to copy targets for VS insertion in the old MSBuild project in VS repo. This is no longer needed as we achieve this using custom build logic in the project file itself.
Used when merging xplat branch. No longer needed.
Nirmal4G
changed the title
Remove Unused Tasks.UnitTests2 project
Remove unused files from the repo
Mar 2, 2021
Forgind
approved these changes
Mar 4, 2021
benvillalobos
approved these changes
Mar 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
benvillalobos
added
the
merge-when-branch-open
PRs that are approved, except that there is a problem that means we are not merging stuff right now.
label
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
merge-when-branch-open
PRs that are approved, except that there is a problem that means we are not merging stuff right now.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6190
Context
Remove unused projects and files in the repo. Part of the larger refactoring that'll lead into #1686
Changes Made
netci.groovy
file.RunApiPort.bat
file.runApiCompat.bat
file.CompatBaseline.txt
file.src\Tasks\DefaultTasks.bat
file.src\Tasks.UnitTests2
project.Testing
NIL
Notes
DefaultTasks.bat
file.Tasks.UnitTests2
project.These are a part of XMake project in VS repo.
These are not used in the build process in this repo.