Make sure that *.* always means all files in FileMatcher #6235
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
#6151 introduced a regression where
FileMatcher
takes the pattern*.*
too literally and returns only files that have a dot in the name.*.*
should be special cased to mean all files in the directory, with or without an extension.Changes Made
Fixed the regression by explicitly testing for
*.*
and added test coverage.Testing
Existing and modified unit tests, repro project from dotnet/sdk#16185 (comment).
Notes
Testing for both
*
and*.*
is already happening elsewhere in the class. MSBuild callsDirectory.EnumerateFileSystemEntries
which under the covers usesMatchType.Win32
and causes this behavior of unifying*.*
with*
on all platforms.