Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inheritdoc #6246

Merged
merged 1 commit into from
Mar 13, 2021
Merged

Remove inheritdoc #6246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/Tasks/RoslynCodeTaskFactory/RoslynCodeTaskFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,6 @@ public sealed class RoslynCodeTaskFactory : ITaskFactory
/// <inheritdoc cref="ITaskFactory.FactoryName"/>
public string FactoryName => "Roslyn Code Task Factory";

/// <inheritdoc />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 This was inheriting from

msbuild/src/Framework/ITaskFactory.cs

Lines 20 to 23 in 40beb5a

/// <summary>
/// Gets the type of the task this factory will instantiate. Implementations must return a value for this property.
/// </summary>
Type TaskType { get; }

While it's perfectly valid to include both <inheritdoc/> and other content, it only has an impact when the inherited documentation contains elements that are not manually replaced (e.g. if the inherited documentation had <remarks> or <value>, but this property only contained <summary>.

/// <summary>
/// Gets the <see cref="T:System.Type" /> of the compiled task.
/// </summary>
Expand Down