Code

Opt Into Perf Logging#6274

Code

Merged

benvillalobos merged 35 commits intodotnet:maindotnet/msbuild:mainfrom benvillalobos:opt-into-perf-loggingbenvillalobos/msbuild:opt-into-perf-loggingCopy head branch name to clipboardApr 15, 2021

+17-3

Commits

Commits on Mar 16, 2021

• Add DOTNET_PERFLOG_DIR environment variable when we call the build script for official builds

  benvillalobos

  committed
  24c3e42

  Copy full SHA for 24c3e42

• Publish perflogs for pipeline builds

  benvillalobos

  committed
  5c4781d

  Copy full SHA for 5c4781d

• Check if env var is null or empty, try creating the directory if it doesn't exist

  benvillalobos

  committed
  26d8deb

  Copy full SHA for 26d8deb

• Modify unit test to account for performance logger creating the directory to log to

  benvillalobos

  committed
  ded3e03

  Copy full SHA for ded3e03

Commits on Mar 19, 2021

• Strip away any quotes in the env var

  benvillalobos

  committed
  fda5165

  Copy full SHA for fda5165

• Opt into perf logging during bootstrap builds

  benvillalobos

  committed
  7c8f351

  Copy full SHA for 7c8f351

• Revert "Add DOTNET_PERFLOG_DIR environment variable when we call the build script for official builds"

  Show description for 6babc3f
  benvillalobos

  committed
  6babc3f

  Copy full SHA for 6babc3f

• Revert "Publish perflogs for pipeline builds"

  Show description for 6ac7122
  benvillalobos

  committed
  6ac7122

  Copy full SHA for 6ac7122

• Add publish step for perf logs in CI builds

  benvillalobos

  committed
  b7cbda6

  Copy full SHA for b7cbda6

• Revert "Add publish step for perf logs in CI builds"

  Show description for 2c96e62
  benvillalobos

  committed
  2c96e62

  Copy full SHA for 2c96e62

• Rename output directory to PerformanceLogs

  benvillalobos

  committed
  bb577df

  Copy full SHA for bb577df

• Have the only non-bootstrap build run before all bootstrap builds

  benvillalobos

  committed
  f5dbbfe

  Copy full SHA for f5dbbfe

Commits on Mar 24, 2021

• Dont pass a null string into TrimAndStripAnyQuotes

  benvillalobos

  committed
  002145c

  Copy full SHA for 002145c

• DEBUG: Add console writelines on perflogeventlistener creation

  benvillalobos

  committed
  202e0fd

  Copy full SHA for 202e0fd

Commits on Mar 25, 2021

• Add performance logging to cibuild_bootstrapped_msbuild shell script for macos and linux

  benvillalobos

  committed
  cde91c9

  Copy full SHA for cde91c9

• Don't strip quotes from env var.

  Show description for 85c68db
  benvillalobos

  committed
  85c68db

  Copy full SHA for 85c68db

• Allow 5 retries for uploading perf logs.

  Show description for afb9c2b
  benvillalobos

  committed
  afb9c2b

  Copy full SHA for afb9c2b

Commits on Mar 31, 2021

• DEBUG: Add powershell script to output details on the process holding the file

  benvillalobos

  committed
  83b808a

  Copy full SHA for 83b808a

• DEBUG: Fix path in powershell script

  benvillalobos

  committed
  4b091df

  Copy full SHA for 4b091df

Commits on Apr 1, 2021

• DEBUG: Powershell task has a name. Kills msbuild and vbcscompiler processes to allow file copies

  benvillalobos

  committed
  84a1905

  Copy full SHA for 84a1905

• Debug: Powershell task only kills processes

  benvillalobos

  committed
  fc90d2a

  Copy full SHA for fc90d2a

Commits on Apr 2, 2021

• Revert "DEBUG: Add console writelines on perflogeventlistener creation"

  Show description for 3280482
  benvillalobos

  committed
  3280482

  Copy full SHA for 3280482

• Revert "Allow 5 retries for uploading perf logs."

  Show description for eae3885
  benvillalobos

  committed
  eae3885

  Copy full SHA for eae3885

• Revert "Have the only non-bootstrap build run before all bootstrap builds"

  Show description for 41f0fc6
  benvillalobos

  committed
  41f0fc6

  Copy full SHA for 41f0fc6

• Run powershell script for correct windows build tasks

  benvillalobos

  committed
  2df6127

  Copy full SHA for 2df6127

• Try naming powershell task for clarity

  benvillalobos

  committed
  2fce6e2

  Copy full SHA for 2fce6e2

• Capitalize the displayname of the powershell task

  benvillalobos

  committed
  57987d3

  Copy full SHA for 57987d3

Commits on Apr 5, 2021

• DEBUG: Print out command line for lingering processes to find the log for the killed process. Verify it logged everything it needed to

  benvillalobos

  committed
  f1230ac

  Copy full SHA for f1230ac

• Fix indents

  benvillalobos

  committed
  1cc8885

  Copy full SHA for 1cc8885

• Run dotnet build-server shutdown instead of taskkill

  benvillalobos

  committed
  86be063

  Copy full SHA for 86be063

• Set environment variable to disable node reuse

  benvillalobos

  committed
  1eed79b

  Copy full SHA for 1eed79b

Commits on Apr 12, 2021

• Disable nodereuse for test that spawns lingering msbuild.exe

  benvillalobos

  committed
  6a4a460

  Copy full SHA for 6a4a460

• Remove disablenodereuse env variable from cibuild script

  benvillalobos

  committed
  5f1fb73

  Copy full SHA for 5f1fb73

Commits on Apr 13, 2021

• Prevent test assemblies from logging performance info by clearing the environment variable

  benvillalobos

  committed
  424e50a

  Copy full SHA for 424e50a

• Revert "Disable nodereuse for test that spawns lingering msbuild.exe"

  Show description for 32900ee
  benvillalobos

  committed
  32900ee

  Copy full SHA for 32900ee