-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update branding for 17.0 #6408
Update branding for 17.0 #6408
Conversation
README.md
Outdated
|
||
[![Build Status](https://dev.azure.com/dnceng/public/_apis/build/status/Microsoft/msbuild/msbuild-pr?branchName=main)](https://dev.azure.com/dnceng/public/_build/latest?definitionId=86&branchName=main) | ||
|
||
We have forked for MSBuild 16.9 in the branch [`vs16.9`](https://github.com/dotnet/msbuild/tree/vs16.9). Changes to that branch need special approval. | ||
We have forked for MSBuild 16.11 in the branch [`vs16.11`](https://github.com/Microsoft/msbuild/tree/vs16.11). Changes to that branch need special approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a possibility we will still need to service 16.10, although it's not LTS so not mentioning it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we merge the vs17.0
branch back into main first?
In my head we should do these things, in either order
- Merge Update Visual Studio Version to 17.0 #6361 (maybe with the readme change here added?)
- Merge
vs17.0
tomain
I don't think cherry-picking is the right move since we should have clean merges.
Merging |
I think 1 should go first. It should have been a part of the branding in the first place—it wouldn't make sense to have even a build that's partway between dev16 and dev17. |
@Forgind I am planning to delete
EDIT: There's actually step 0. Merge #6409 so |
Works for me |
branding update
Is there any reason we have to delete vs17.0? We've created vs16.x branches before they're really properly full before. Are we just going slower here because we have so long before 17.0 ships? Also, are we then planning to have main insert into VS main and rel/d17, or are we planning to abandon rel/d17? |
No strong reason to delete, it's just not needed until the next snap. VS It's a good analogy, though. I'm not deleting and will keep the branch around. Thank you! |
Context
Mainline development is switching to Visual Studio 17.0.
Changes Made
Merging current
vs17.0
branch into main to pick up branding changes.Testing
Grepped the tree for other occurrences of 16.10.
Notes