Add reserved properties MSBuildFileVersion and MSBuildSemanticVersion #6534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forgind
approved these changes
Jun 11, 2021
There was a problem hiding this comment.
I'm not too worried about breaking users, and the changes look good. I'm wondering more about how much added value this has. Are people asking for it? This is in a very perf-sensitive area, and I've been hearing of issues with adding too many things impacting perf.
It's useful to tool writers. sdk writers, and general build enthusiasts that follow msbuild changes at the intra-preview granularity, and so they need to differentiate beyond the first two version numbers.
What perf concerns in particular do you have about this change? |
rainersigwald
approved these changes
Jun 14, 2021
Forgind
added
the
merge-when-branch-open
cdmihai
added a commit
to cdmihai/visualstudio-docs
that referenced
this pull request
Jun 17, 2021
The MSBuild change (dotnet/msbuild#6534) will ship with VS 16.11.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
There's no easy way to get all of MSBuild's version numbers at evaluation time or build time.
Changes Made
Added
MSBuildFileVersionandMSBuildSemanticVersion. With these two, users should have all the information they require to mix and match all the version components they want:Testing
Updated version test.
Note
Targeting 16.11 as it only adds new stuff that should not break. Caveat is if users define the new built-in properties. We'll break those users. Though I think those users don't exist :)